Patch posted to dev list.

Posted a patch a while ago that was theoretically accepted for testing. Any idea what happened to it?

What’s the status of this? Is it “Ready for testing” or “Tests insufficient” ?

Any chance that this could get into 2.7.3 final?

So the code is good and the tests are good, but it was never merged in time for the 2.7.0 release?

I’m still not clear on why this whole process took so long or who sat on it, but my first reaction would be that this should target Telly as it’s adding new features, particularly given how complex and yet fundamental the File type is in Puppet.

Are there good reasons why we should add a feature this far into the 2.7.x series?

Nigel Kersten wrote:

So the code is good and the tests are good, but it was never merged in time for the 2.7.0 release?

Looks to be, to me.

I’m still not clear on why this whole process took so long or who sat on it, but my first reaction would be that this should target Telly as it’s adding new features, particularly given how complex and yet fundamental the File type is in Puppet.

Looks like it just got dropped, and no one really noticed until Trevor asked again.

Are there good reasons why we should add a feature this far into the 2.7.x series?

Personally, I favour putting forward compatible features (eg: will work in 2.7.3+, but not 2.7.2) into our less feature-focused releases. It is also a fine feature, and should be rolled in to the product … and we sat for more than a year on Trevor’s contribution. Getting that sorted out sooner would be awesome, and Telly means that we would have close to another year before it rolled out beyond our code to actual production systems – for something that has very few real compatibility concerns, IMO.

All, thanks for picking this back up.

I was happy to wait for this until 2.7.X, but I’d like to get this in before 2.8 if possible since 2.8 is going to require a great deal of testing to be sure that the dynamic lookup issues are all properly addressed.

Thanks,

Trevor

Trevor Vaughan wrote:

All, thanks for picking this back up.

I was happy to wait for this until 2.7.X, but I’d like to get this in before 2.8 if possible since 2.8 is going to require a great deal of testing to be sure that the dynamic lookup issues are all properly addressed.

Sorry it got dropped in the first place. We will get this into 2.8 in the very near future, but it won’t land in 2.7 at this time. Thanks again for the contribution, and sorry about the long delay in getting it rolled out.

Sorry for the delays around merging this: the code is still correct, and it just needs the merge conflicts sorted out by hand because it was outstanding for so long. The security issues last week got in the way of the merge, but I hope to get it in by the end of this week.

Thanks for your patience.

Any update on getting this merged?

On Tue, Nov 1, 2011 at 08:12, tickets@puppetlabs.com wrote:

Sorry Trevor, as you may have seen we had a cluster of security issues that dominated our attention over the last month.

Trevor, let me add my voice to that: it has explicitly been that set of security issues that have delayed this, rather than anything specific to the code.

Note that this is going into Telly, not into 2.7.x Daniel, are you the best person to do the merge?

There was some hand work required because the Windows changes perturbed code in the region. It might be worth getting the OSS team, who also handled the Windows changes, to look at doing this?