Bug #2860

Test isolation: unrelated tests cause spurious failures in spec/unit/parser/resource/reference.rb

Added by Markus Roberts about 2 years ago. Updated about 2 years ago.

Status:Duplicate Start date:11/25/2009
Priority:Low Due date:
Assignee:Markus Roberts % Done:

0%

Category:testing
Target version:0.25.2
Affected Puppet version:0.25.1 Branch:
Keywords:
Votes: 0

Description

Running spec/unit/application/puppetdoc.rb before spec/unit/parser/resource/reference.rb, e.g. with

touch spec/unit/application/puppetdoc.rb
ruby spec/unit/application/puppetdoc.rb spec/unit/parser/resource/reference.rb -t 60 --format s --loadby mtime

Causes spurious failures:

- should canonize resource reference values (FAILED - #)

Related issues

related to Puppet - Bug #2830: Rspec test failures for 0.25.x HEAD (pre-0.25.2) Rejected 11/18/2009
duplicates Puppet - Bug #2675: File path comparisons sensitive to trailing slashes Closed 09/24/2009

History

Updated by Markus Roberts about 2 years ago

  • Subject changed from Test isolation: spec/unit/application/puppetdoc.rb causes failures in spec/unit/parser/resource/reference.rb to Test isolation: sunrelated tests cause spurious failures in spec/unit/parser/resource/reference.rb

puppetdoc isn’t special; any of the following (and perhaps others) have the same effect:

spec/unit/util/filetype.rb spec/unit/parser/ast/function.rb spec/unit/parser/ast/casestatement.rb spec/integration/ssl/certificate_authority.rb spec/unit/property/ordered_list.rb spec/unit/parser/functions/sprintf.rb spec/integration/file_serving/metadata.rb spec/unit/ssl/certificate_authority.rb spec/integration/indirector/catalog/compiler.rb spec/unit/provider/user/ldap.rb spec/unit/application/puppetdoc.rb spec/unit/parser/functions/regsubst.rb spec/unit/network/format_handler.rb spec/unit/indirector/key/file.rb spec/unit/parser/functions/split.rb spec/unit/simple_graph.rb spec/unit/provider/confine/exists.rb spec/unit/ssl/key.rb spec/shared_behaviours/memory_terminus.rb spec/integration/util/file_locking.rb spec/integration/node.rb spec/integration/file_serving/content.rb spec/integration/checksum.rb spec/integration/type.rb spec/unit/util/user_attr.rb spec/unit/indirector/catalog/yaml.rb spec/unit/provider/zpool/solaris.rb spec/unit/type/zpool.rb spec/unit/type/augeas.rb spec/unit/indirector/terminus.rb spec/unit/indirector/report/processor.rb spec/unit/parser/functions/shellquote.rb spec/unit/indirector/code.rb spec/unit/file_serving/base.rb spec/unit/node/environment.rb spec/unit/reports.rb

Updated by Markus Roberts about 2 years ago

  • Subject changed from Test isolation: sunrelated tests cause spurious failures in spec/unit/parser/resource/reference.rb to Test isolation: unrelated tests cause spurious failures in spec/unit/parser/resource/reference.rb
  • Assignee changed from Jesse Wolfe to Markus Roberts

Updated by Markus Roberts about 2 years ago

  • Target version changed from 0.25.2 to 0.25.3

I’m pushing this one out to 0.25.3 because it does not appear to be consistently reproducible (there appears to be some other confounding factor in addition to the ordering). I suspected it might have to do with the loading of libraries, but was unable to confirm this because after adding code to dump $“ I was unable to reproduce it.

Updated by Markus Roberts about 2 years ago

Just reproduced this on Ubuntu as of commit:“b86decc0ea”.

Updated by Markus Roberts about 2 years ago

  • Status changed from Accepted to Duplicate

The problem (as Jesse discovered in fixing the re-opened #2675) was that field initialization was order-indeterminate, so the type (needed for type-specific canonization) was not always set before the title.

Updated by James Turnbull about 2 years ago

  • Target version changed from 0.25.3 to 0.25.2

Also available in: Atom PDF