Bug #2830
Rspec test failures for 0.25.x HEAD (pre-0.25.2)
| Status: | Rejected | Start date: | 11/18/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Markus Roberts |
% Done: | 0% |
|
| Category: | testing | |||
| Target version: | 0.25.2 | |||
| Affected Puppet version: | 0.25.1 | Branch: | ||
| Keywords: | ||||
| Votes: | 0 |
Description
1)
'Puppet::Parser::Resource::Reference should canonize resource reference values' FAILED
expected: "File[/tmp/yay]",
got: "File[/tmp/yay/]" (using ==)
./spec/unit/parser/resource/reference.rb:50:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
2)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should catch and log errors during CSR saving'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- allowed any number of times, already invoked once: #.sleep(any_parameters)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:657:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
3)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should sleep and retry after failures saving the CSR if waitforcert is enabled'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- expected exactly once, already invoked once: #.sleep(1)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:664:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
4)
'Puppet::Indirector::FileContent::FileServer when finding files should find plugin file content in the environment specified in the request' FAILED
expected nil? to return false, got true
./spec/integration/indirector/file_content/file_server.rb:38:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
5)
'puppetmasterd should create a PID file' FAILED
expected true, got false
./spec/integration/bin/puppetmasterd.rb:67:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
6)
Puppet::SSLCertificates::Support::MissingCertificate in 'puppetmasterd should be serving status information over xmlrpc'
No host certificate
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:82:in `mk_cert'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `send'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `cert'
./spec/integration/bin/puppetmasterd.rb:84:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
7)
'Puppet::Type::File when writing files should fail if no backup can be performed' FAILED
expected: "bar\n",
got: "foo" (using ==)
./spec/integration/type/file.rb:54:
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
Finished in 160.392702 seconds
7278 examples, 7 failures, 29 pending
Related issues
History
Updated by James Turnbull over 2 years ago
- Status changed from Unreviewed to Investigating
Updated by James Turnbull over 2 years ago
- Assignee set to Markus Roberts
Updated by Markus Roberts over 2 years ago
The first failure is caused by #2860
Updated by James Turnbull over 2 years ago
More failures:
1)
'Puppet::Node::Environment when modeling a specific environment.modules should create modules with the correct environment' FAILED
expected: "testing",
got: #[#>]}, @cache_timestamp=Fri Dec 04 07:58:17 +1100 2009, @ttl_timestamps={:modules=>Fri Dec 04 07:58:17 +1100 2009}, @mocha=#> (using ==)
./spec/unit/node/environment.rb:174:
./spec/unit/node/environment.rb:174:in `each'
./spec/unit/node/environment.rb:174:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
2)
NameError in 'Puppet::Network::FormatHandler should include all supported formats'
undefined local variable or method `indirection' for FormatTester:Class
/home/james/src/puppet/lib/puppet/network/format_handler.rb:137:in `put_preferred_format_first'
/home/james/src/puppet/lib/puppet/network/format_handler.rb:122:in `supported_formats'
./spec/unit/network/format_handler.rb:33:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
3)
NameError in 'Puppet::Network::FormatHandler should return the supported formats in decreasing order of weight'
undefined local variable or method `indirection' for FormatTester:Class
/home/james/src/puppet/lib/puppet/network/format_handler.rb:137:in `put_preferred_format_first'
/home/james/src/puppet/lib/puppet/network/format_handler.rb:122:in `supported_formats'
./spec/unit/network/format_handler.rb:49:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
4)
NameError in 'Puppet::Network::FormatHandler with a preferred serialization format setting that is supported should return the preferred serialization format first'
undefined local variable or method `indirection' for FormatTester:Class
/home/james/src/puppet/lib/puppet/network/format_handler.rb:124:in `supported_formats'
./spec/unit/network/format_handler.rb:66:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
5)
NameError in 'Puppet::Network::FormatHandler with a preferred serialization format setting that is not supported should still return the default format first'
undefined local variable or method `indirection' for FormatTester:Class
/home/james/src/puppet/lib/puppet/network/format_handler.rb:137:in `put_preferred_format_first'
/home/james/src/puppet/lib/puppet/network/format_handler.rb:122:in `supported_formats'
./spec/unit/network/format_handler.rb:74:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
6)
NameError in 'Puppet::Network::FormatHandler with a preferred serialization format setting that is not supported should log a warning'
undefined local variable or method `indirection' for FormatTester:Class
/home/james/src/puppet/lib/puppet/network/format_handler.rb:137:in `put_preferred_format_first'
/home/james/src/puppet/lib/puppet/network/format_handler.rb:122:in `supported_formats'
./spec/unit/network/format_handler.rb:78:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
7)
'Puppet::Type::File when writing files should fail if no backup can be performed' FAILED
expected: "bar\n",
got: "foo" (using ==)
./spec/integration/type/file.rb:54:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
8)
'puppetmasterd should create a PID file' FAILED
expected true, got false
./spec/integration/bin/puppetmasterd.rb:67:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
9)
Puppet::SSLCertificates::Support::MissingCertificate in 'puppetmasterd should be serving status information over xmlrpc'
No host certificate
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:82:in `mk_cert'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `send'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `cert'
./spec/integration/bin/puppetmasterd.rb:84:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
10)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should catch and log errors during CSR saving'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- allowed any number of times, already invoked once: #.sleep(any_parameters)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:657:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
11)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should sleep and retry after failures saving the CSR if waitforcert is enabled'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- expected exactly once, already invoked once: #.sleep(1)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:664:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
12)
'Puppet::Indirector::FileContent::FileServer when finding files should find plugin file content in the environment specified in the request' FAILED
expected nil? to return false, got true
./spec/integration/indirector/file_content/file_server.rb:38:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
13)
'Puppet::Type::Mount::ProviderParsed Puppet::Type::Mount::ProviderParsed when modifying the filesystem tab should write the mount to disk when :flush is called' FAILED
expected: "/dev/dsk1\t/fspuppet1\tfakefstype1\tfakeoptions1\tfakedump1\tfakepass1\n",
got: "/dev/VolGroup00/LogVol01\t/\text3\tdefaults\t1\t1\nLABEL=/boot\t/boot\text3\tdefaults\t1\t2\ntmpfs\t/dev/shm\ttmpfs\tdefaults\t0\t0\ndevpts\t/dev/pts\tdevpts\tgid=5,mode=620\t0\t0\nsysfs\t/sys\tsysfs\tdefaults\t0\t0\nproc\t/proc\tproc\tdefaults\t0\t0\n/dev/VolGroup00/LogVol00\tswap\tswap\tdefaults\t0\t0\n/dev/dsk1\t/fspuppet1\tfakefstype1\tfakeoptions1\tfakedump1\tfakepass1\n" (using ==)
./spec/unit/provider/mount/parsed.rb:146:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
Finished in 208.899452 seconds
7290 examples, 13 failures, 29 pending
Updated by James Turnbull over 2 years ago
Updated since #2886:
1)
'Puppet::Node::Environment when modeling a specific environment.modules should create modules with the correct environment' FAILED
expected: "testing",
got: #[#>]}, @mocha=#, @cache_timestamp=Fri Dec 04 10:39:10 +1100 2009, @ttl_timestamps={:modules=>Fri Dec 04 10:39:10 +1100 2009}> (using ==)
./spec/unit/node/environment.rb:174:
./spec/unit/node/environment.rb:174:in `each'
./spec/unit/node/environment.rb:174:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
2)
'Puppet::Type::File when writing files should fail if no backup can be performed' FAILED
expected: "bar\n",
got: "foo" (using ==)
./spec/integration/type/file.rb:54:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
3)
'puppetmasterd should create a PID file' FAILED
expected true, got false
./spec/integration/bin/puppetmasterd.rb:67:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
4)
Puppet::SSLCertificates::Support::MissingCertificate in 'puppetmasterd should be serving status information over xmlrpc'
No host certificate
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:82:in `mk_cert'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `send'
/home/james/src/puppet/lib/puppet/sslcertificates/support.rb:45:in `cert'
./spec/integration/bin/puppetmasterd.rb:84:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
5)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should catch and log errors during CSR saving'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- allowed any number of times, already invoked once: #.sleep(any_parameters)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:657:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
6)
Mocha::ExpectationError in 'Puppet::SSL::Host when waiting for a cert should sleep and retry after failures saving the CSR if waitforcert is enabled'
not all expectations were satisfied
unsatisfied expectations:
- expected exactly twice, already invoked once: #.generate(any_parameters)
satisfied expectations:
- expected exactly once, already invoked once: #.sleep(1)
- expected exactly twice, already invoked twice: #.certificate(any_parameters)
./spec/unit/ssl/host.rb:664:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
7)
'Puppet::Indirector::FileContent::FileServer when finding files should find plugin file content in the environment specified in the request' FAILED
expected nil? to return false, got true
./spec/integration/indirector/file_content/file_server.rb:38:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
8)
'Puppet::Type::Mount::ProviderParsed Puppet::Type::Mount::ProviderParsed when modifying the filesystem tab should write the mount to disk when :flush is called' FAILED
expected: "/dev/dsk1\t/fspuppet1\tfakefstype1\tfakeoptions1\tfakedump1\tfakepass1\n",
got: "/dev/VolGroup00/LogVol01\t/\text3\tdefaults\t1\t1\nLABEL=/boot\t/boot\text3\tdefaults\t1\t2\ntmpfs\t/dev/shm\ttmpfs\tdefaults\t0\t0\ndevpts\t/dev/pts\tdevpts\tgid=5,mode=620\t0\t0\nsysfs\t/sys\tsysfs\tdefaults\t0\t0\nproc\t/proc\tproc\tdefaults\t0\t0\n/dev/VolGroup00/LogVol00\tswap\tswap\tdefaults\t0\t0\n/dev/dsk1\t/fspuppet1\tfakefstype1\tfakeoptions1\tfakedump1\tfakepass1\n" (using ==)
./spec/unit/provider/mount/parsed.rb:146:
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:22:in `run'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `each'
/home/james/src/puppet/spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'
Finished in 152.04612 seconds
7290 examples, 8 failures, 29 pending
Updated by Markus Roberts over 2 years ago
- Status changed from Investigating to Rejected
James —
After trying to work with this format a while I’ve come to the conclusion that an ever changing list of unrelated error messages does not a useful ticket make. Especially when many (but possibly not all) of them duplicate other more specific tickets.
I’m committed to getting to all green on the tests, but this ticket isn’t helping and isn’t likely to help in the future. If you see a spec failure (or set of clearly related failures) that isn’t getting addressed on a ticket, open a ticket specifically for it. That way, at least we’ll know when we’ve fixed it.
— Markus
Updated by James Turnbull over 2 years ago
Markus – so to be clear if I have 30 individual spec failures (or groups of failures) you want me to open individual tickets for each failure or group of failures? Whilst I understand your logic I suspect users other than me aren’t likely to do so.