Puppet

Luke Kanies wrote:

I’ll look for that patch, but until it shows up we won’t associate it with a release.

I have that patch, but I still need to figure out how to mail it. I simply do not get the git stuff, its the horror for me.

You can add it to the ticket if you can’t figure out the mail.

However, you should be able to use the ‘mail_patches’ rake target, as described in the lifecycle page:

http://reductivelabs.com/trac/puppet/wiki/Development/DevelopmentLifecycle

I’m trying to puzzle out from the -dev list if this was approved – together with #2819? Nigel?

patch #2

line 17: can we be consistent about quoting symbols used in requires please? Can we please make “ditto” a command in case it’s pulled in future versions of OS X and so we get all the free functionality in Puppet? Shouldn’t we have some error handling around all the file writing/reading operations? This looks like it will fail badly for a corrupt yaml dbfile?

That’s about it for me, having never used the appdmg provider at all.

Actually, I’m confused by which patches are doing what and may have made useless comments.

Can we just have the whole diff mailed to the dev list? It’s harder to read this way…. :(

Brian, as you can see from the ticket log, we didn’t get much of a response on the dev list, and I’m not even sure what the patch looks like that we’d be commenting on.