Bug #2795
puppetdoc parser fails without useful error message
| Status: | Closed | Start date: | 11/10/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  James Turnbull |
% Done: | 0% |
|
| Category: | documentation | |||
| Target version: | 0.25.2 | |||
| Affected Puppet version: | 0.25.1 | Branch: | tickets/master/2795 | |
| Keywords: | ||||
| Votes: | 0 |
Description
when puppetdoc’s parser fails, it does not give too much useful information about the problem:
kjetilho@puppetmaster:~$ puppetdoc —mode rdoc —config /etc/puppet/puppet.conf —modulepath /var/lib/puppet/svn/modules —manifestdir /etc/puppet/manifests —outputdir doc Could not generate documentation: undefined method `value' for #<Puppet::Parser::AST::Selector:0x2b905199ccf0>
by adding —verbose, you can guess what file caused the problem, but you still don’t get line number information.
Related issues
History
Updated by James Turnbull over 2 years ago
- Category set to documentation
- Status changed from Unreviewed to Accepted
- Assignee set to Brice Figureau
- Target version set to 0.25.2
Updated by Brice Figureau over 2 years ago
- Status changed from Accepted to Ready For Checkin
- Assignee changed from Brice Figureau to James Turnbull
- Branch set to tickets/master/2795
Fixed for master in tickets/master/2795 in my github repository: http://github.com/masterzen/puppet/tree/tickets/master/2795
Fixed for 0.25.2 in tickets/0.25.x/2795 still in my github repository: http://github.com/masterzen/puppet/tree/tickets/0.25.x/2795
This also fixes #2796.
Updated by Kjetil Torgrim Homme over 2 years ago
thanks, Brice!
respectfully, I’d like to point out that this bug isn’t really fixed as far as I can tell — if an unexpected exception happens, you will still not get information about where and what caused it.
Updated by Kjetil Torgrim Homme over 2 years ago
I beg your pardon, I just didn’t find my way around github. the patch posted to puppet-dev clearly covers it.
Updated by James Turnbull over 2 years ago
- Status changed from Ready For Checkin to Closed
Pushed in commit:391786f0b43e514d58336f465bc53fb7a5c34884 in master and commit:5f7177efeae81c86086d73b3c7869302cfc6a40d in branch 0.24.x