Puppet

When puppetd is triggered by puppetrun without —tags on the command line, the @tags@ ruby object is set to @[“”]@ which fails the code below resulting in all resources being skipped and not applied.

Here is a snippet of the debug output from puppetd during a run triggered by puppetrun:

debug: //mysql-cluster::mysql-cluster-gpl/File[mysql-cluster-gpl-ebuild]: Not tagged with 
debug: //mysql-cluster::mysql-cluster-gpl/Exec[eix-update-mysql-cluster]: Not tagged with 
debug: //mysql-cluster::mysql-cluster-gpl/Package[mysql-cluster-gpl]: Not tagged with 

Here is the offending code and patch:

--- transaction.rb      2009-11-04 20:58:35.000000000 -0700
+++ transaction-new.rb  2009-11-04 21:05:22.000000000 -0700
@@ -619,7 +619,7 @@
 
     # Is this resource tagged appropriately?
     def missing_tags?(resource)
-        return false if self.ignore_tags? or tags.empty?
+        return false if self.ignore_tags? or tags.empty? or tags == [""]
         return true unless resource.tagged?(tags)
     end

I don’t speak ruby all that well, so it is hard to tell where the fix should be applied. The patch above does fix the problem, but it might not be the proper place. Perhaps the fix should be where puppetd sets the @tags@ object when receiving a puppetrun request.