Bug #2781
Case statements with colons break Ruby 1.9.x compatibility
| Status: | Closed | Start date: | 11/04/2009 | |
|---|---|---|---|---|
| Priority: | Low | Due date: | ||
| Assignee: |  James Turnbull |
% Done: | 0% |
|
| Category: | unknown | |||
| Target version: | 0.25.2 | |||
| Affected Puppet version: | 0.25.1 | Branch: | http://github.com/MarkusQ/puppet/tree/ticket/master/2781 | |
| Keywords: | ruby 1.9 | |||
| Votes: | 0 |
Description
In order to get Puppet to properly work on Ruby 1.9.x case statements cannot use a colon after each particular case. There are some places in lib/puppet/rails.rb and lib/puppet/type/file.rb that use this syntax which breaks under Ruby 1.9.x
Attached is a patch to fix these case statements and also an attempted run of puppetd —trace —verbose —debug to show Puppet failing to startup without this patch
Note there are is some more changes in order to get the puppet client daemon to properly run on Ruby 1.9.x after these case statements
Related issues
History
Updated by Peter Meier over 2 years ago
can you send the patches to puppet-dev ? –> http://reductivelabs.com/trac/puppet/wiki/Development/DevelopmentLifecycle#submitting-patches thanks!
Updated by James Turnbull over 2 years ago
- Status changed from Unreviewed to Investigating
- Assignee set to James Turnbull
- Target version set to 0.25.2
Updated by Markus Roberts over 2 years ago
- Status changed from Investigating to Accepted
The issue description is sound and the patch looks acceptable (with the one minor aesthetic issue I noted on the list being the trailing semicolons).
Updated by Markus Roberts over 2 years ago
- Status changed from Accepted to Ready For Checkin
- Branch set to http://github.com/MarkusQ/puppet/tree/ticket/master/2781
I’ve put Al’s patch up with trailing “;"s removed at http://github.com/MarkusQ/puppet/tree/ticket/master/2781
Updated by James Turnbull over 2 years ago
- Status changed from Ready For Checkin to Closed
Pushed in commit:b1c57e9c15b1b7f079dc99dfc79e57fe3e5682e0 in branch 0.25.x