Bug #2769

Puppet doesn't create default schedule in 0.25.1

Added by Brice Figureau over 2 years ago. Updated over 2 years ago.

Status:Closed Start date:11/01/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:RAL
Target version:0.25.2
Affected Puppet version:0.25.1 Branch:tickets/0.25.x/2769
Keywords:schedule
Votes: 0

Description

This is a regression from 0.24.8 where the default schedule were created (ie daily, hourly and so on).

manifest:

node a.domain.org {
  file {
    "/tmp/a": content => "a", schedule => daily;
  }
}

And the produced error:

/Users/brice/devl/puppet/lib/puppet/util/errors.rb:51:in `fail'
/Users/brice/devl/puppet/lib/puppet/type.rb:1745:in `schedule'
/Users/brice/devl/puppet/lib/puppet/type.rb:1757:in `scheduled?'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:569:in `scheduled?'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:589:in `skip?'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:202:in `eval_resource'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:294:in `evaluate'
/Users/brice/devl/puppet/lib/puppet/util.rb:417:in `thinmark' 
/opt/local/lib/ruby/1.8/benchmark.rb:308:in `realtime'
/Users/brice/devl/puppet/lib/puppet/util.rb:416:in `thinmark'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:293:in `evaluate'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:287:in `collect'
/Users/brice/devl/puppet/lib/puppet/transaction.rb:287:in `evaluate'
/Users/brice/devl/puppet/lib/puppet/resource/catalog.rb:142:in `apply'
/Users/brice/devl/puppet/lib/puppet/configurer.rb:147:in `run'
/Users/brice/devl/puppet/lib/puppet/util.rb:177:in `benchmark' 
/opt/local/lib/ruby/1.8/benchmark.rb:308:in `realtime'
/Users/brice/devl/puppet/lib/puppet/util.rb:176:in `benchmark'
/Users/brice/devl/puppet/lib/puppet/configurer.rb:146:in `run'
/Users/brice/devl/puppet/lib/puppet/agent.rb:53:in `run'
/Users/brice/devl/puppet/lib/puppet/agent/locker.rb:21:in `lock'
/Users/brice/devl/puppet/lib/puppet/agent.rb:53:in `run'
/opt/local/lib/ruby/1.8/sync.rb:229:in `synchronize'
/Users/brice/devl/puppet/lib/puppet/agent.rb:53:in `run'
/Users/brice/devl/puppet/lib/puppet/agent.rb:130:in `with_client'
/Users/brice/devl/puppet/lib/puppet/agent.rb:51:in `run'
/Users/brice/devl/puppet/lib/puppet/application/puppetd.rb:103:in `onetime'
/Users/brice/devl/puppet/lib/puppet/application.rb:226:in `send'
/Users/brice/devl/puppet/lib/puppet/application.rb:226:in `run_command'
/Users/brice/devl/puppet/lib/puppet/application.rb:217:in `run'
/Users/brice/devl/puppet/lib/puppet/application.rb:306:in `exit_on_fail'
/Users/brice/devl/puppet/lib/puppet/application.rb:217:in `run'sbin/puppetd:159 
err: Could not apply complete catalog: Could not find schedule daily at /Users/brice/devl/puppet-manifest/puppe/manifests/site.pp:334

Note: it works with the @puppet@ command, it is only when using a puppetmaster.

I think we don’t call anymore Puppet::Resource::Catalog#make_default_resource. I yet have to find why.

History

#1
Updated by James Turnbull over 2 years ago

  • Status changed from Unreviewed to Accepted

#2
Updated by James Turnbull over 2 years ago

  • Assignee set to Brice Figureau

#3
Updated by Brice Figureau over 2 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee changed from Brice Figureau to James Turnbull
  • Branch set to tickets/0.25.x/2769

James,

The patch was approved on puppet-dev. It is available in my github repository in the branch tickets/0.25.x/2769: http://github.com/masterzen/puppet/tree/tickets/0.25.x/2769

It can also be merged to master without too many hassles.

thanks, brice

#4
Updated by James Turnbull over 2 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:5b750c225ff0c646341282aa867d92dbe15509cd in branch 0.25.x

Also available in: Atom PDF