Bug #2753
fileserver.conf allow/deny directives not honored for [modules], [plugins]
| Status: | Closed | Start date: | 10/26/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Brice Figureau |
% Done: | 0% |
|
| Category: | - | |||
| Target version: | 0.25.1 | |||
| Affected Puppet version: | 0.25.1rc2 | Branch: | ||
| Keywords: | ||||
| Votes: | 0 |
Description
When adding allow or deny access controls to [modules] and [plugins] in fileserver.conf, those directives are not applied. They are statically set to allow(‘’) in /usr/lib/ruby/site_ruby/1.8/puppet/file_serving/configuration.rb begining on lines 99 and 101. I propose having fileserver.conf allow/deny options only being autoset to allow(‘’) if no other [modules], [plugins] access directives exist.
Related issues
History
Updated by James Turnbull over 2 years ago
- Status changed from Unreviewed to Investigating
- Assignee set to Brice Figureau
- Target version set to 0.25.1
Updated by Brice Figureau over 2 years ago
- Status changed from Investigating to Accepted
Steve Wilson wrote:
When adding allow or deny access controls to [modules] and [plugins] in fileserver.conf, those directives are not applied. They are statically set to allow(‘’) in /usr/lib/ruby/site_ruby/1.8/puppet/file_serving/configuration.rb begining on lines 99 and 101. I propose having fileserver.conf allow/deny options only being autoset to allow(‘’) if no other [modules], [plugins] access directives exist.
Yes, that makes sense. Bug appeared in commit:17205bb4e5d246f7a47b995826927a38b83fb3d0 (see #2424).
I’ll post a patch tonight.
Updated by James Turnbull over 2 years ago
- Status changed from Accepted to Ready For Checkin
Can you add the branch Brice – and I’ll push. Thanks
Updated by James Turnbull over 2 years ago
- Status changed from Ready For Checkin to Closed
Pushed in commit:6b254ebc606b128cbf4d778023da3c4cc396fe29 in branch 0.25.x