Bug #2671

preferred_serialization_format does not complain about invalid values

Added by R.I. Pienaar over 2 years ago. Updated about 2 years ago.

Status:Closed Start date:09/22/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:serialization
Target version:0.25.2
Affected Puppet version:0.25.0 Branch:http://github.com/bruce/puppet/tree/ticket/0.25.x/2671
Keywords:
Votes: 0

Description

Puppet should log if you pass bogus formats to preferred_serialization_format rather than silently falling back to yaml.

# puppetd --onetime --test --preferred_serialization_format foo
info: Caching catalog for dev1.pinetecltd.net
info: Applying configuration version '1253646355'
notice: Finished catalog run in 0.20 seconds

History

#1
Updated by James Turnbull over 2 years ago

  • Category set to serialization
  • Status changed from Unreviewed to Accepted
  • Target version set to 0.25.2

#2
Updated by Markus Roberts over 2 years ago

  • Assignee set to Anonymous

#3
Updated by Anonymous over 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Anonymous to Markus Roberts
  • Branch set to http://github.com/bruce/puppet/tree/ticket/0.25.x/2671
This modifies `supported_formats` to warn when the
`preferred_serialization_format` setting is invalid (and ignored in
favor of the default value).

I built the tests for this behavior alongside the existing
FormatHandler tests for *valid* `preferred_serialization_format` values
(and did some restructuring to extract common setup code to `before`
blocks).

#4
Updated by James Turnbull about 2 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin
  • Assignee changed from Markus Roberts to James Turnbull

#5
Updated by James Turnbull about 2 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:7f2e5fc51b64d5a9281a7e65a88b378b1c99d03f in branch 0.25.x

#6
Updated by Peter Meier about 2 years ago

Using latest 0.25.x I know get

warning: Value of 'preferred_serialization_format' ('pson') is invalid, using default ('yaml')

maybe because for pson supported? is missing? –> http://github.com/bruce/puppet/blob/a1624d08efeeb9b11da1046177445efebbd32ea7/lib/puppet/network/formats.rb

#7
Updated by Peter Meier about 2 years ago

maybe because for pson supported? is missing? –> http://github.com/bruce/puppet/blob/a1624d08efeeb9b11da1046177445efebbd32ea7/lib/puppet/network/formats.rb

could verify that. Open a new bug for that

Also available in: Atom PDF