Bug #2633

unhelpful error message -- incorrect values for file/recurse are hard to debug

Added by seph seph over 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:09/14/2009
Priority:Normal Due date:
Assignee:Jesse Wolfe % Done:

0%
Category:error reporting
Target version:0.25.2
Affected Puppet version:0.25.0rc1 Branch:http://github.com/jes5199/puppet/tree/ticket/0.25.x/2633
Keywords:
Votes: 0

Description

seph@samhain-test:~$ cat /var/tmp/puppet-recurse.pp 
file{ "/tmp/recurese-test":
    ensure  => directory,
    recurse => yes,
    owner   => root,
    group   => root,
    mode    => 640,
}

seph@samhain-test:~$ puppet --version
0.25.0
seph@samhain-test:~$ sudo puppet -v  /var/tmp/puppet-recurse.pp
info: Loading facts in virtual
info: Loading facts in acpi_available
info: Loading facts in interfaces
sh: Syntax error: Bad fd number
sh: Syntax error: Bad fd number
Parameter recurse failed: Munging failed for value "yes" in class recurse: Invalid recurse value "yes"

I get a similarly hard to unravel message with any other unrecognized value, not just yes.

Related issues

related to Puppet - Bug #2822: Unhelpful error message when an undefined variable is use... Closed 11/16/2009
related to Puppet - Bug #2856: Setting recursion depth with the recurse parameter is now... Rejected 11/25/2009

History

#1
Updated by Markus Roberts over 2 years ago

  • Status changed from Unreviewed to Needs More Information
  • Assignee set to seph seph

Could you explain further? “Yes” is not a valid value for the recurse parameter, and the error message seems to state that.

I may be being dense but I’m not understanding what specifically is hard to unravel.

— MarkusQ

P.S. If you could give an example of what you think the error should have been that might help.

#2
Updated by seph seph over 2 years ago

Sorry for the brevity of the initial report.

While the error is accurate, it does not include mention of the file, line number or resource type. As a non-expert, it’s very hard to track down an error with out much to go on. “recurse” might have been a suitable keyword, but it’s pretty generic. My first parsing of that error, was that I’d screwed something up i my inheritance, and some internal recurse function was failing. It took a lot of reverts before I finally found the problem.

Some places in puppet give much better errors. For example, if I type “Fcile” instead of “File” I get:

err: Could not retrieve catalog from remote server: Error 400 on SERVER: Could not find resource type fcile at /etc/puppet/modules/site/manifests/test.pp:9 on node puppet-test.example.com

Much simpler to track that down. In contrast this error gives me very little to go on.

#3
Updated by seph seph over 2 years ago

  • Assignee deleted (seph seph)

#4
Updated by Markus Roberts over 2 years ago

  • Status changed from Needs More Information to Accepted
  • Assignee set to Markus Roberts

#5
Updated by Markus Roberts about 2 years ago

  • Category set to error reporting
  • Assignee changed from Markus Roberts to Jesse Wolfe
  • Target version set to 0.25.2

#6
Updated by Jesse Wolfe about 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/jes5199/puppet/tree/ticket/0.25.x/2633

#7
Updated by Markus Roberts about 2 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

It now produces:

Parameter recurse failed: Invalid recurse value "yes" at /Users/markus/projects/puppet/jesse/puppet/2633.pp:7

#8
Updated by James Turnbull about 2 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:d685f446ef88c2273a5e3f310d2ebb2bff9091f8 in branch 0.25.x

Also available in: Atom PDF