Bug #2573

fqdn is wrong if nodename is not the first part of fqdn

Added by Benedikt Böhm over 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:08/27/2009
Priority:High Due date:
Assignee:Paul Nasrat % Done:

0%
Category:-
Target version:1.5.8
Keywords: Affected Facter version:
Branch:
Votes: 0

Description

the logic in fqdn.rb is too naive because it does no DNS checks. concatenation of hostname and domainname does not work in case the hostname/nodename is not the same as the first part of the FQDN:

# cat /etc/hosts
78.47.63.169    a.newthinking-ns.de ns1
# hostname
ns1
# hostname -f
a.newthinking-ns.de
# facter | grep fqdn
fqdn => ns1.newthinking-ns.de

this should probably be solved together with bug 2085 by implementing correct dns resolution for fqdn.rb

Related issues

related to Facter - Bug #3898: fqdn fact requires reverse PTR matches the forward Duplicate 05/27/2010

History

#1
Updated by Benedikt Böhm over 2 years ago

  • 3 changed from Unknown to Trivial

pull http://github.com/hollow/facter/commit/ab07f5f7e3ba4bcfa33999ece9080f5bc0bf0c15

#2
Updated by Benedikt Böhm over 2 years ago

as a follow up, this should fix all dns problem currently open in facter. i have commented on the other bugs too: http://github.com/hollow/facter/commit/92f6b049724a620f3833dde10b8126a70ce52a08

#3
Updated by Paul Nasrat over 2 years ago

  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Assignee set to Paul Nasrat
  • Target version set to 1.6.0

Mailed trivial patch to list. See my comment in other bug re external dep in 92f6b049724a620f3833dde10b8126a70ce52a08

#4
Updated by Paul Nasrat over 2 years ago

  • Target version changed from 1.6.0 to 1.5.7

#5
Updated by Paul Nasrat over 2 years ago

  • Target version changed from 1.5.7 to 1.6.0

Re targetting to 1.6.0 so we can solve all the dns issues in one go.

#6
Updated by James Turnbull over 2 years ago

  • Priority changed from Normal to High

#7
Updated by James Turnbull about 2 years ago

  • Target version changed from 1.6.0 to 1.5.8

#8
Updated by Paul Nasrat almost 2 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

#9
Updated by Paul Nasrat almost 2 years ago

  • Status changed from Ready For Checkin to Closed

Commited Ohad’s patch.

Also available in: Atom PDF