Feature #2568

add puppetmasterd 'dbconnections' option to increase rails 'max pool size'

Added by Richard Soderberg over 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:08/25/2009
Priority:Normal Due date:
Assignee:- % Done:

0%
Category:Rails
Target version:2.6.0
Affected Puppet version:0.25.4 Branch:
Keywords:rails database connections max pool size
Votes: 2

Description

the attached patch adds a new option ‘dbconnections’ which tells ActiveRecord the max pool size of the rails connection pool when using ‘mysql’ or ‘postgres’ storeconfig.

ref: http://groups.google.com/group/puppet-users/msg/eab8ee9092dd308c ref: http://www.ruby-forum.com/topic/178429

patch includes changes for all files containing the term ‘dbuser’, including docs and tests and a helper utility. i hope that’s enough.

patch is against git as of a few minutes, all changes pulled before producing the diff.

dbconnections.txt - add database option 'dbconnections' that sets the ActiveRecords connection pool size, when connecting to remote databases (mysql, postgres). default is 0; the 'pool' argument is only passed to ActiveRecords when the value is 1 or greater. (4.1 kB) Richard Soderberg, 11/19/2009 09:01 pm

History

#1
Updated by James Turnbull over 2 years ago

  • Status changed from Unreviewed to Needs Decision
  • Assignee set to Luke Kanies

#2
Updated by Luke Kanies over 2 years ago

  • Status changed from Needs Decision to In Topic Branch Pending Review
  • Assignee deleted (Luke Kanies)
  • Target version set to 2.6.0

#3
Updated by James Turnbull about 2 years ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

Can you please rebase this patch against current master HEAD.

#4
Updated by Richard Soderberg about 2 years ago

  • File patch added

done, also submitted pull request through github

#5
Updated by Richard Soderberg about 2 years ago

  • File deleted (patch)

#6
Updated by Richard Soderberg about 2 years ago

  • File deleted (dbconnections.txt)

#7
Updated by Richard Soderberg about 2 years ago

patch applies cleanly to 2d137e2e1ce603ee2727d66b1aba57458bf4d1be

#8
Updated by James Turnbull about 2 years ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

Pushed to -dev list for comment.

#9
Updated by James Turnbull about 2 years ago

  • Status changed from In Topic Branch Pending Review to Closed

Pushed in commit:c9f40be6c567d8de328b9d79dde357672323925a in branch master.

#10
Updated by micah - almost 2 years ago

  • Affected Puppet version changed from 0.24.8 to 0.25.4

I’m getting this now fairly regularly on 0.25.4, I’ve tried to space out my clients hitting the puppetmaster as much as possible, but it seems like I’ve optimized that as far as I can. It would be nice if I could bump up this parameter much sooner than rowlf… any chance this could be targetted for 0.25.5?

Oh, I also setup puppetqd+stompserver, but that doesn’t seem to be enough, as I am still getting it.

Also available in: Atom PDF