Feature #2518

store datetime fields in UTC instead of localtime

Added by Ohad Levy almost 3 years ago. Updated 6 months ago.

Status:Tests Insufficient Start date:08/09/2009
Priority:Low Due date:
Assignee:- % Done:

0%
Category:stored configuration
Target version:-
Affected Puppet version:0.24.8 Branch:http://github.com/nicklewis/puppet/tree/feature/0.25.x/2518-store_datetime_in_utc
Keywords:
Votes: 2

Description

Curretnly the store config option stores the last_compile etc fields with local time, it would be useful to store it in UTC when having multiple puppetmasters / locations.

History

#1
Updated by James Turnbull almost 3 years ago

  • Category set to plumbing
  • Status changed from Unreviewed to Needs Decision
  • Assignee set to Luke Kanies

#2
Updated by Luke Kanies almost 3 years ago

  • Status changed from Needs Decision to Accepted
  • Assignee deleted (Luke Kanies)

#3
Updated by Nick Lewis almost 2 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Branch set to http://github.com/nicklewis/puppet/tree/feature/0.25.x/2518-store_datetime_in_utc

I took the old code for this from the mailing list and added it to a github branch. Here’s the thread, since I’m not sure what the final decision was on this code:

http://groups.google.com/group/puppet-dev/browse_thread/thread/af19d649ab1b2429/f0493ed60a1fd0a9

#4
Updated by James Turnbull almost 2 years ago

Is this aimed at a release?

#5
Updated by James Turnbull over 1 year ago

  • Target version set to 2.7.x

#6
Updated by Nigel Kersten about 1 year ago

  • Target version deleted (2.7.x)

#7
Updated by James Turnbull 9 months ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient
  • Assignee set to Nick Lewis

Can’t find this branch in your repository any longer.

#8
Updated by Ohad Levy 9 months ago

http://groups.google.com/group/puppet-dev/browse_thread/thread/af19d649ab1b2429/f0493ed60a1fd0a9?lnk=gst&q=2518#f0493ed60a1fd0a9

thanks

#9
Updated by James Turnbull 9 months ago

Ohad – any chance of a branch and a pull request? Thanks.

#10
Updated by Ohad Levy 9 months ago

https://github.com/puppetlabs/puppet/pull/73

#11
Updated by James Turnbull 9 months ago

  • Status changed from Code Insufficient to In Topic Branch Pending Review

Awesome thanks mate!

#12
Updated by James Turnbull 7 months ago

  • Category changed from plumbing to stored configuration

#13
Updated by Jacob Helwig 6 months ago

  • Status changed from In Topic Branch Pending Review to Tests Insufficient
  • Assignee deleted (Nick Lewis)

Ohad,

Looking at the pull request the commit message would need to be cleaned up to follow the guidelines in CONTRIBUTING.md, and would need to add at least one test around this behavior to make sure it doesn’t accidentally get broken.

I’m also a bit concerned about how this would interact with people’s existing databases if they upgrade to a version with this change, largely because I’m unaware of how this will really interact with people’s storedconfigs setups (this is definitely information that belongs in the commit message). Is there anything other than storedconfigs that will be affected by this?

Also available in: Atom PDF