Refactor #2387
The Parser should use a separate class to manage loaded code
| Status: | Closed | Start date: | 07/02/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Luke Kanies |
% Done: | 0% |
|
| Category: | parser | |||
| Target version: | 0.25.0 | |||
| Affected Puppet version: | 0.24.8 | Branch: | ||
| Keywords: | ||||
| Votes: | 0 |
Description
Current HEAD has an ASTSet struct to manage the code in memory, but access to this struct is not protected so we can’t do any sort of race condition protection.
We should pull this into a separate class and protect all access to it, so it’s easy to wrap that access in mutexes if necessary.
I’ve got the code done already, as an attempt to prepare to fix #2294.
Related issues
History
Updated by Luke Kanies over 2 years ago
- Status changed from Accepted to In Topic Branch Pending Review
Pushed in my tickets/master/2387 repo.
Updated by James Turnbull over 2 years ago
- Status changed from In Topic Branch Pending Review to Closed
Pushed in commit:fc1f8cdbee606da0d2a1a162942295d28cdcbf64 and commit:cddc365e9bac786c7a64240073b69bc54b6d2f2e in branch master.