Bug #2341
Facter::Manufacturer.dmi_find_system_info splits on non-unique delimiter
| Status: | Closed | Start date: | 06/14/2009 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% |
|
| Category: | library | |||
| Target version: | 1.5.8 | |||
| Keywords: | Affected Facter version: | |||
| Branch: | ||||
| Votes: | 1 |
Description
dmi_find_system_info splits the dmidecode output on ‘Handle’, however this delimiter may also occur within a valid ‘line’. Here is an example of dmidecode output:
Handle 0x1000, DMI type 16, 15 bytes
Physical Memory Array
Location: System Board Or Motherboard
Use: System Memory
Error Correction Type: None
Maximum Capacity: 4 GB
Error Information Handle: Not Provided
Number Of Devices: 2
Which is incorrectly split as:
0x1000, DMI type 16, 15 bytes
Physical Memory Array
Location: System Board Or Motherboard
Use: System Memory
Error Correction Type: None
Maximum Capacity: 4 GB
Error Information
and
: Not Provided
Number Of Devices: 2
This makes it impossible for the function to locate the final two values.
Changing splitstr to /Handle/ makes the delimiter split the output correctly.
History
Updated by James Turnbull almost 3 years ago
- Category set to library
- Status changed from Unreviewed to Accepted
- Target version set to 1.6.0
Updated by James Turnbull over 2 years ago
- Target version changed from 1.6.0 to 1.5.8
Updated by Paul Nasrat over 2 years ago
- Status changed from Accepted to In Topic Branch Pending Review
Patch and test mailed to list.
Updated by Frank Sorenson over 2 years ago
This bug is not addressed in the available patch, and isn’t tested with the test case. The dmidecode output above is still split incorrectly.
Updated by Paul Nasrat over 2 years ago
- Status changed from In Topic Branch Pending Review to Ready For Checkin
Reviewed on list
Updated by Paul Nasrat over 2 years ago
- Status changed from Ready For Checkin to Closed
commit :7750f036539afa4ad04aef676ab27c551e97ad3e