Bug #2328

Whitespace cleanup

Added by Ian Taylor over 2 years ago. Updated almost 2 years ago.

Status:Closed Start date:06/05/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%

Category:plumbing
Target version:0.25.0
Affected Puppet version:0.24.8 Branch:
Keywords:
Votes: 1

Description

There would be too many patches to clean this up for each file individually.

h3. I have split this up into 3 patches

Go from tabs to spaces without destroying alignment or indentation

Fix indentation to the correct number of spaces per level as specified by the style guide

Remove dangling whitespace at the end of lines

These should patch cleanly against commit @00d5139639afe9b206f2f68df95cebfeb28f28b1@

Once applied with @git apply@, @git diff -w@ should confirm that the changes are to whitespace only (with exceptions of files that had no newline on the last line, those were added too)

Previously, some of my changes made a @rake unit@ test fail, so I scaled back from modifying whitespace/indentation in multi-line strings.

0001-Changed-tabs-to-spaces-without-interfering-with-inde.patch (585.3 kB) Ian Taylor, 06/05/2009 04:13 pm

0002-Changed-indentation-to-be-more-consistent-with-style.patch (99.3 kB) Ian Taylor, 06/05/2009 04:13 pm

0003-Removed-extra-whitespace-from-end-of-lines.patch (819.7 kB) Ian Taylor, 06/05/2009 04:13 pm

History

Updated by Luke Kanies over 2 years ago

  • Status changed from Unreviewed to Accepted

I can’t review the code right now, and I’m heading out for a short vacation, but if the code passes muster, I’m all about cleaning up whitespace issues.

Updated by James Turnbull over 2 years ago

Code looks good to me. I’m going to apply it.

Updated by James Turnbull over 2 years ago

  • Category set to plumbing
  • Status changed from Accepted to Closed
  • Assignee set to James Turnbull
  • Target version set to 0.25.0

Pushed in master.

Also available in: Atom PDF