Puppet » Facter

TODO after #2292 merged

isn’t the current detection, based on the fact that /proc/vz/version exists, a lot simpler than doing regex and ==/> comparison?

Benedikt Böhm wrote:

isn’t the current detection, based on the fact that /proc/vz/version exists, a lot simpler than doing regex and ==/> comparison?

Maybe. But /proc/self/status is read anyway already in the virtual fact, so reading more files is pointless.

Christian Hofstaedtler wrote:

Benedikt Böhm wrote:

isn’t the current detection, based on the fact that /proc/vz/version exists, a lot simpler than doing regex and ==/> comparison?

Maybe. But /proc/self/status is read anyway already in the virtual fact, so reading more files is pointless.

The problem is that it’s not reliable that way, all that has to happen is a file being put into that directory to break the logic.

This is solid and all in one nice little statement:

(%x[cat /proc/self/status | awk ‘$1 == “envID:” {print $2}’]) ? result = “openvzhn” : result =“openvzve”

I’m happy to follow the recommendation of anyone who uses OpenVZ a lot. Anyone?

What I said in the original report still holds true. The point of this was that virtual.rb already gets a lot of info out of /proc/self/status, so OpenVZ detection can also use this. Obviously this is only useful if virtual.rb would read /proc/self/status once, and then do all the testing against the file contents in memory. Else this will still fork a lot more than needed and therefore be unnecessarily slow.

The information is technically correct, from someone who knows OpenVZ well. :)

What I am not certain of is what, if any, information the LXC-based containers expose in this regard. I assume they don’t bundle the various namespace segregations, so they don’t expose a single “environment ID” like value, but would want confirmation from someone who knows that part of the Linux kernel code.

Ben, I think we’re missing the actual branch this is in?

https://github.com/barn/facter/tree/ticket%2F1.5.9%2F6728-facter_improperly_detects_openvzve_on_cloudlinux_systems