Feature #2205

More HP-UX Facts

Added by Sam Rowe about 3 years ago. Updated almost 2 years ago.

Status:Closed Start date:04/27/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%

Category:library
Target version:1.5.8
Keywords:hpux Affected Facter version:
Branch:
Votes: 0

Description

I have a bunch of code. Trying very hard to get it submitted. Code submission so far more difficult than writing the code.

I didn’t know about the naming conventions for branches and mail_patches, so hopefully this will suffice. If not let me know what to do and update http://reductivelabs.com/trac/puppet/wiki/DevelopmentLifecycle with the correct info. Btw, that page still points users to git clone git://reductivelabs.com/puppet in one spot and github in another and is generally written from the assumption that you already know what to do. I’d update it, but I don’t know what’s correct.

0001-facts-for-HP-UX.patch (2.8 kB) Sam Rowe, 04/27/2009 02:38 pm

History

Updated by Paul Nasrat about 3 years ago

  • Status changed from Unreviewed to In Topic Branch Pending Review

OK

you should be able to do:

git clone git://github.com/reductivelabs/facter.git 
# Create ticket branch
git checkout -t -b tickets/master/2205 master
# or git checkout -t -b tickets/1.5.x/2205 1.5.x

Make changes/apply patch commit, I saved your email from list and did

git am ~/facter-2205.patch

I’ve pushed this here http://github.com/pnasrat/facter/tree/tickets/master/2205

Finally you can mail the list using

rake mail_patches 

Updated by James Turnbull about 3 years ago

  • Target version set to 1.5.5

Updated by Paul Nasrat about 3 years ago

Based on conversations with Sam there are issues with these facts long running and killing puppet.

This may have to wait until further investigation can be made.

Updated by James Turnbull about 3 years ago

  • Target version changed from 1.5.5 to 1.6.0

Updated by Paul Nasrat over 2 years ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient

Updated by Paul Nasrat over 2 years ago

  • Assignee set to Paul Nasrat
  • Keywords set to hpux

I don’t have access to HP-UX, the killing puppet is likely to be Issue #2211 which I’m looking into.

Sam the two facts that use getconf look fairly light weight, if you run with just those do you experience the killing of puppet?

If not can you rediff with just those facts and we can revisit more HP-UX info post #2211

Updated by Sam Rowe almost 2 years ago

This can be closed. #3989 replaced this code.

Updated by James Turnbull almost 2 years ago

  • Category set to library
  • Status changed from Code Insufficient to Closed
  • Target version changed from 1.6.0 to 1.5.8

Updated by James Turnbull almost 2 years ago

  • Status changed from Closed to Re-opened
  • Assignee changed from Paul Nasrat to James Turnbull

Sam – actually are you sure? There are facts here other than the networking ones?

Updated by Sam Rowe almost 2 years ago

  • Status changed from Re-opened to Closed

I’m sure.

Also available in: Atom PDF