Bug #2172

service provider for gentoo fails with ambiguous suffixes

Added by Benedikt Böhm about 3 years ago. Updated about 2 years ago.

Status:Closed Start date:04/19/2009
Priority:High Due date:
Assignee:Luke Kanies % Done:

0%
Category:Gentoo
Target version:0.25.0
Affected Puppet version:0.24.8 Branch:
Keywords:
Votes: 0

Description

if one service is a suffix for another service (as nscd is for unscd) the @enabled?@ method does not correctly identify the service and fails to enable/disable it.

0001-identify-services-with-ambiguous-suffixes-correctly.patch (961 Bytes) Benedikt Böhm, 04/19/2009 11:26 am

History

#1
Updated by James Turnbull about 3 years ago

  • Status changed from Unreviewed to Accepted
  • Target version set to 0.25.0

#2
Updated by James Turnbull about 3 years ago

  • Target version changed from 0.25.0 to 2.6.0

#3
Updated by Benedikt Böhm about 3 years ago

  • Priority changed from Normal to High

why has this been postponed unti 0.26.0? this is such a trivial fix that it should even go into 0.24.9 if such a release is planned …

#4
Updated by James Turnbull about 3 years ago

  • Status changed from Accepted to Closed
  • Target version changed from 2.6.0 to 0.25.0

Pushed in commit:284cbeb6a6b4b8d633890139b8e5c5319f67bde3 in branch master.

#5
Updated by Alexey Lapitsky over 2 years ago

btw, it checks out only 2 runlevels – boot and default. maybe we should change regexp for matching any runlevel (\w+) ?

#6
Updated by Luke Kanies over 2 years ago

Alexey Lapitsky wrote:

btw, it checks out only 2 runlevels – boot and default. maybe we should change regexp for matching any runlevel (w+) ?

What are the various repercussions of this? Does Gentoo have other runlevels?

I don’t see a problem with it on first blush. Is there code for this, or is it really just a regex change? What about tests?

#7
Updated by Benedikt Böhm over 2 years ago

Luke Kanies wrote:

I don’t see a problem with it on first blush. Is there code for this, or is it really just a regex change? What about tests?

gentoo has as many runlevels as you wish. these are called soflevels and usually init is configured to boot into the ‘default’ runlevel with init 3.

i don’t see a problem with changing the regex to \w+. it should match all runlevels then.

Also available in: Atom PDF