Bug #2149

Client facts should be sent to server as request parameters

Added by Luke Kanies almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:04/09/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:plumbing
Target version:0.25.0
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 0

Description

In order to support shared-nothing on the server, the client facts need to be sent as attributes to the Catalog.find call on the client, rather than in a separate request.

This should be straightforward, and should all take place in the Configurer class.

I don’t know whether it’s best to just serialize the Facts instance and pass that as an argument, or to set each of the facts as request parameters. Probably the former, so there’s no collision between the two.

History

#1
Updated by Luke Kanies almost 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Luke Kanies to James Turnbull

Fixed in the tickets/master/2149 branch in my repo.

#2
Updated by Luke Kanies almost 3 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

I’ve tested this as much as I think is reasonable, and I don’t see anyone else kicking it around, so….

#3
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Code Insufficient
  • Assignee changed from James Turnbull to Luke Kanies

Can you rebase this one on current HEAD?

#4
Updated by Luke Kanies almost 3 years ago

  • Status changed from Code Insufficient to Ready For Checkin
  • Assignee changed from Luke Kanies to James Turnbull

Done.

#5
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in branch master.

Also available in: Atom PDF