Bug #2142

pkdmg provider should require puppet/util/plist rather than scanning for strings in XML output

Added by Nigel Kersten over 1 year ago. Updated 4 months ago.

Status:Closed Start:04/07/2009
Priority:Normal Due date:
Assignee:Nigel Kersten % Done:

100%
Category:Darwin
Target version:0.25.0
Affected version:0.24.8 Branch:
Keywords:
Votes: 0

Description

Currently the pkgdmg provider does some rather hacky stuff with string scanning to find the mountpoint for a mounted dmg.

This should be converted to use the plist module instead.

Additionally, it assumes that a mountrandom request on /tmp results in a dereferenced mountpoint in /tmp, whereas it is hypothetically possible that future OS X releases may actually return this value as /private/tmp.

History

#1
Updated by Nigel Kersten over 1 year ago

  • % Done changed from 0 to 100

0.24.x fix pushed in:

http://github.com/nigelkersten/puppet/tree/tickets/0.24.x/2142 http://github.com/nigelkersten/puppet/commit/216e8ba8ce66d9c1a3f6f30561a9eca03b486169

This really should get applied to 0.25.x given that a new 0.24.x release is unlikely.

Let me know if you want me to explicitly patch against 0.25.x, but afaik no-one has done any work on this provider in 0.25

Patch sent to dev list, waiting on approval.

#2
Updated by Nigel Kersten over 1 year ago

  • Status changed from Accepted to Ready for Checkin

After feedback from the dev-list, here is the accepted commit.

http://github.com/nigelkersten/puppet/tree/tickets/0.24.x/2142 http://github.com/nigelkersten/puppet/commit/e2fde8d1acf13e8ecedf7393f4836e1548866ff3

As mentioned before, should be fine to check into 0.25.x as well as 0.24.x

#3
Updated by Luke Kanies over 1 year ago

  • Target version set to 0.25.0

Is there any reason this shouldn’t be in 0.25?

#4
Updated by James Turnbull over 1 year ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“50e0f3d0161bc4160e36a93d15fba53302b8727b” in branch master.

Also available in: Atom PDF