Bug #2099

chmod typo in 0.24.8 install.rb

Added by Grumpus the Cat almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:03/23/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:installation
Target version:0.24.8
Affected Puppet version:0.24.8 Branch:
Keywords:
Votes: 0

Description

The function do_libs sets the parent directory’s mode to 644. This seems to be the case in both the tarball and the gem (though not in the GIT repo):

--- puppet-0.24.8.orig/install.rb       2009-03-22 23:38:26.000000000 -0400
+++ puppet-0.24.8/install.rb    2009-03-23 11:48:10.000000000 -0400
@@ -93,7 +93,7 @@
     olf = File.join(InstallOptions.site_dir, lf.gsub(/#{strip}/, ''))
     op = File.dirname(olf)
     File.makedirs(op, true)
-    File.chmod(0644, op)
+    File.chmod(0755, op)
     File.install(lf, olf, 0755, true)
   end
 end

History

#1
Updated by Grumpus the Cat almost 3 years ago

grumpus wrote:

The function do_libs sets the parent directory’s mode to 644. This seems to be the case in both the tarball and the gem (though not in the GIT repo):

I was wrong regarding the GIT repo. I was looking at the master branch, not the 0.24.8 tag. The incorrect mode is also set in GIT on the 0.24.8 tag.

#2
Updated by James Turnbull almost 3 years ago

  • Category set to installation
  • Status changed from Unreviewed to Closed
  • Assignee set to James Turnbull
  • Target version set to 0.24.8

Thanks – I fixed this and rebuild the package.

Also available in: Atom PDF