Bug #2077

ralsh user is busticated on OS X

Added by Andrew Shafer almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:03/14/2009
Priority:Normal Due date:
Assignee:Nigel Kersten % Done:

100%
Category:-
Target version:0.24.8
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 0

Description

/Users/andrew/git/puppet/lib/puppet/provider/nameservice/directoryservice.rb:121:in get_macosx_version_major': undefined local variable or methoddetail' for Puppet::Type::User::ProviderDirectoryservice:Class (NameError)

    from /Users/andrew/git/puppet/lib/puppet/provider/nameservice/directoryservice.rb:268:in `get_exec_preamble'
    from /Users/andrew/git/puppet/lib/puppet/provider/nameservice/directoryservice.rb:137:in `list_all_present'
    from /Users/andrew/git/puppet/lib/puppet/provider/nameservice/directoryservice.rb:94:in `instances'
    from /Users/andrew/git/puppet/lib/puppet/type.rb:1238:in `instances'
    from /Users/andrew/git/puppet/lib/puppet/type.rb:1237:in `collect'
    from /Users/andrew/git/puppet/lib/puppet/type.rb:1237:in `instances'
    from /Users/andrew/git/puppet/bin/ralsh:247

There is an issue because ‘detail’ doesn’t exist. This is trying to raise, and building a string that doesn’t make sense.

This is about line 121 of lib/puppet/provider/nameservice/directoryservice.rb

product_version = Facter.value(:macosx_productversion)

if product_version.nil?
   raise Puppet::Error, "Could not determine OS X version: %s" % detail
end

When I run facter by itself: baraka:~ andrew$ facter | grep productversion macosx_productversion => 10.5.5

We need CI for ralsh…

History

#1
Updated by Nigel Kersten almost 3 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Nigel Kersten

#2
Updated by Nigel Kersten almost 3 years ago

  • Target version set to 0.24.8
  • 3 changed from Unknown to Trivial

So it looks like we didn’t have #1962 pushed properly?

I’m fixing both that commit and the incorrect string error now and sending to the list.

#3
Updated by Nigel Kersten almost 3 years ago

  • % Done changed from 0 to 100

Patch sent to dev list.

#4
Updated by Nigel Kersten almost 3 years ago

Pushed to: http://github.com/nigelkersten/puppet/tree/tickets/0.24.x/2077

in:

http://github.com/nigelkersten/puppet/commit/609d9c385af01dc546d3801369bc93ff44ea678f

#5
Updated by Nigel Kersten almost 3 years ago

  • Status changed from Accepted to Ready For Checkin

#6
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:2c7e1897eaaa7d2dd8d8d993df8a9a217d1c46c6 in branch 0.24.x

Also available in: Atom PDF