Bug #1972

ActiveRecord fixes resulted in broken tests

Added by Luke Kanies almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:02/14/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

100%
Category:Rails
Target version:0.24.8
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 0

Description

  1) Error:
test_to_rails(TestExportedResources):
NameError: uninitialized constant Puppet::Rails::ParamValues
    /Library/Ruby/Gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:263:in `load_missing_constant'
    /Library/Ruby/Gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:453:in `const_missing'
    /Users/luke/git/puppet/lib/puppet/rails/resource.rb:60:in `get_params_hash'
    /Users/luke/git/puppet/lib/puppet/rails/resource.rb:99:in `parameters'
    ./rails/railsresource.rb:219:in `test_to_rails'
    /Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `__send__'
    /Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `run'

  9) Failure:
test_parameters(TestRailsResource)
    [./rails/railsresource.rb:81:in `test_parameters'
     /Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `__send__'
     /Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `run']:
Exception raised:
Class: 
Message: <"uninitialized constant Puppet::Rails::ParamValues">
---Backtrace---
/Library/Ruby/Gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:263:in `load_missing_constant'
/Library/Ruby/Gems/1.8/gems/activesupport-2.0.2/lib/active_support/dependencies.rb:453:in `const_missing'
/Users/luke/git/puppet/lib/puppet/rails/resource.rb:60:in `get_params_hash'
/Users/luke/git/puppet/lib/puppet/rails/resource.rb:99:in `parameters'
./rails/railsresource.rb:82:in `test_parameters'
./rails/railsresource.rb:81:in `test_parameters'
/Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `__send__'
/Library/Ruby/Gems/1.8/gems/mocha-0.9.2/lib/mocha/test_case_adapter.rb:69:in `run'
---------------

If I can figure them out I’ll fix them, but I figure Brice has all this stuff pretty near the top of his cache.

History

#1
Updated by Brice Figureau almost 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from Brice Figureau to James Turnbull
  • % Done changed from 0 to 100
  • 3 changed from Unknown to Trivial

Patch available in my github repository branch tickets/0.24.x/1972: http://github.com/masterzen/puppet/tree/tickets/0.24.x/1972

#2
Updated by Luke Kanies almost 3 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin

Works for me.

#3
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:24d48e6c07ef634971fcb8ed5b27258db161a018 in branch 0.24.x

Also available in: Atom PDF