Puppet

Larry Ludwig and I did some memory leak analysis, and found that, especially with multiple environments, file paths can take a significant amount of memory. Based on some simplistic analysis, they can take up to 50% of the memory in the master.

We need some kind of file collection we can use to store no more than one copy of each file path during parsing.

We should probably have a similar file collection in use on the client, since each resource and parameter also stores the file that it was defined in. Then we use a FileMangler module or something that interactions with this collection. Something like:

module Puppet::Util::FileMangler
  def file=(path)
    @file_reference = file_collection.file_reference(@path)
  end

  def file
    file_collection.file_path(@file_reference)
  end
end