Bug #1964

Per-module facts not loaded when using "puppet" standalone executable

Added by Deepak Giridharagopal almost 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:02/12/2009
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:plumbing
Target version:0.24.8
Affected Puppet version:0.24.7 Branch:
Keywords:
Votes: 0

Description

I have a module, and inside I’ve got a “plugins/facter” directory with some custom facts in it. When I run “puppet” (the standalone executable, with an appropriate modulepath argument), it does not automatically load facts from that directory. If I were using factsync/puppetd, then this would work fine. But this fails in standalone mode.

The problem appears to be inside indirector/facts/facts.rb…it only loads facts found on Puppet[:factpath].

I’ve attached a small patch that modifies the loadfacts method to also load facts from per-module fact directories, which corrects the behavior.

per-module-facts.patch (879 Bytes) Deepak Giridharagopal, 02/12/2009 07:57 pm

History

#1
Updated by Luke Kanies almost 3 years ago

  • Category set to plumbing
  • Status changed from Unreviewed to Accepted
  • Assignee set to Luke Kanies
  • Target version set to 0.24.8

I’ll get this done today.

#2
Updated by Luke Kanies almost 3 years ago

Pushed in tickets/0.24.x/1964 in my repo.

#3
Updated by Luke Kanies almost 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee changed from Luke Kanies to James Turnbull

#4
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:39a8b28690377339d4c430ebf62cec5ef0ed34b8 in branch 0.24.x

Also available in: Atom PDF