Bug #1911

puppet 0.24.7 fails to read/set users/groups on mac 10.4

Added by Peter Woodman about 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:01/28/2009
Priority:Urgent Due date:
Assignee:James Turnbull % Done:

100%
Category:OSX
Target version:0.24.8
Affected Puppet version:0.24.7 Branch:
Keywords:dscl,plist,tiger,mac
Votes: 0

Description

Looks like the directoryservice provider has been changed about to use the -plist flag when calling dscl, but this flag is not supported on 10.4 and results in nothing happening.

This is what I’m getting. I’ve attached a debug run from a client as well as facter output, and you can see that it’s trying to call /usr/bin/dscl -plist. The code difference between 0.24.7 and 0.24.6 seems to support the idea that non-plist output from dscl isn’t supported anymore.

This seems like a really really huge problem for someone to have just missed before putting out a major release – user and group management simply doesn’t work anymore on any machine that isn’t on Leopard – so I’m hoping I’m just missing something here.

j112-mac02:~ root# /usr/bin/dscl -plist .
Cannot open remote host, error: DSOpenDirServiceErr
Data source (-plist) is not valid.
j112-mac02:~ root# uname -a
Darwin j112-mac02.gs.washington.edu 8.11.0 Darwin Kernel Version 8.11.0: Wed Oct 10 18:26:00 PDT 2007; root:xnu-792.24.17~1/RELEASE_PPC Power Macintosh powerpc

puppet.out - debug test run showing puppet calling dscl -plist on 10.4 (28.4 kB) Peter Woodman, 01/28/2009 06:46 am

facter.out - facter output of said machine (1.9 kB) Peter Woodman, 01/28/2009 06:46 am

History

#1
Updated by James Turnbull about 3 years ago

  • Status changed from Unreviewed to Needs More Information
  • Assignee set to Nigel Kersten

Nigel?

#2
Updated by James Turnbull about 3 years ago

  • Target version set to 0.24.8

#3
Updated by Nigel Kersten about 3 years ago

crap. crap. crap. crap.

I can’t believe we missed that.

mccune and I will try to sort this out this week.

#4
Updated by Peter Woodman about 3 years ago

That’s what I get for being too lazy to roll my own packages to test out that refactor you asked me to a while ago.. doh.

#5
Updated by Nigel Kersten about 3 years ago

part of the problem is that this was done to fix another bug relating to comments/real names with spaces in them that was probelematic with the -url output option from before ;(

We may just have to live with that bug on 10.4. I’ll look at this problem properly tonight and see if I can get two code paths working for 10.4 and 10.5

damn you Apple.

#6
Updated by Peter Woodman about 3 years ago

yup- I filed that spaces bug, which makes me a bad person for not checking up on the refactor :)

#7
Updated by Nigel Kersten about 3 years ago

I’ve been really flat out at work. I’m planning to look at these Mac 10.4 issues this weekend and next week. Apologies.

#8
Updated by Nigel Kersten about 3 years ago

Deleting commit lines from this post.

Waiting for approval from dev-list before pushing to github.

#9
Updated by Nigel Kersten almost 3 years ago

  • % Done changed from 0 to 100
  • 3 changed from Unknown to Medium

Done and approved on dev-list.

http://github.com/nigelkersten/puppet/commit/634071b467f2d102c50810a59fccc608891c022c

http://github.com/nigelkersten/puppet/tree/tickets/0.24.x/1911

#10
Updated by Luke Kanies almost 3 years ago

  • Status changed from Needs More Information to Ready For Checkin
  • Assignee changed from Nigel Kersten to James Turnbull

#11
Updated by Peter Woodman almost 3 years ago

awesome, thanks. sorry i haven’t had a chance to test yet- i don’t often get time to work on our mac desktop stuff, but i’ll give it a try as soon as i can.

#12
Updated by James Turnbull almost 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:7f418579f5b0c5df90ff5ea06294028b8d53f385 in branch 0.24.x

Also available in: Atom PDF