Feature #1706

Puppet should use IO#tty? to determine default for colorization

Added by Clayton O'Neill over 3 years ago. Updated over 1 year ago.

Status:Closed Start date:10/28/2008
Priority:Normal Due date:
Assignee:Nigel Kersten % Done:

0%
Category:settings
Target version:-
Affected Puppet version:0.24.6 Branch:
Keywords:
Votes: 0

Description

Puppet should use the IO#tty? to set the default value for colorized output.

I’d be glad to implement this, if it’s seen as worthwhile.

History

#1
Updated by Luke Kanies over 3 years ago

  • Status changed from Unreviewed to Needs Decision

I don’t really like this idea (as mentioned on IRC), because there are plenty of times where I don’t have a tty but still want color — less -X -r is great at showing color but doesn’t have a tty.

The only way I’d even consider this is if it allowed an override so that you could have color even without a tty, but I’d still prefer a default color — it’s 2008, people, your apps can almost definitely handle color at this point.

#2
Updated by Thomas Bellman over 3 years ago

It may be 2008, but it is still a pain to write regexps that handle strange escape sequences when you postprocess the output, with for example grep or awk.

As for an override, I would assume that —color=true would provide that.

(Personally, I dislike output that looks like a christmas tree even for interactive use. It just gives me headaches.)

#3
Updated by Luke Kanies over 3 years ago

  • Status changed from Needs Decision to Accepted

You’ve convinced me.

#4
Updated by Nigel Kersten over 1 year ago

  • Status changed from Accepted to Closed
  • Assignee set to Nigel Kersten

Clayton, still interested in fixing this? Please feel free to reopen if so.

As per the below thread, we’re more aggressively closing tickets whose state is unsure, particularly old tickets with little to no inactivity in a long time.

You are free to reopen them.

http://groups.google.com/group/puppet-users/browse_thread/thread/a040cb9bc5c5b647

Also available in: Atom PDF