Puppet

There are no tests for this. (not just for the patch, at all)

I think I can get them spec’d up this week.

Not knowing anything at all about branded zones (and not much more about zones for that matter) it’s hard for me to judge what is the most appropriate way to manage them. But… I think it is worth exploring managing these with a little more semantic detail.

The commands should not be a single ‘space’ delimited string, at least pass in any array.

The zone provider also has no way to really manage zone attributes. It looks like the management is only one direction and can’t go back to change the attributes of a zone that already exists. That’s a limitation for the moment, but solving that generically seems like a good idea. (but probably not for this simple patch.)

I’d like to talk with coneill about what the command actually look like and then decide if it makes sense to break them out into parameters in the type.

I agree with Andrew — the args should be an array of arguments, rather than a string that you split based on whitespace.