Bug #1682

Array variables not properly flattened

Added by Ryan Steele over 3 years ago. Updated about 2 years ago.

Status:Closed Start date:10/24/2008
Priority:High Due date:
Assignee:James Turnbull % Done:

0%

Category:language
Target version:0.24.7
Affected Puppet version:0.24.6 Branch:
Keywords:
Votes: 0

Description

These should output the same thing, but they do not. This is against the latest version as of today.

manifest version 1

#!/usr/bin/env puppet

$groups = [“foo”, “bar”] $type_groups = [“baz”, “quux”] $user_groups = [$groups, $type_groups]

notify { $user_groups: }

output version 1

root@puppetmaster:/etc/puppet/manifests# ./test.pp notice: foo notice: baz

manifest version 2

#!/usr/bin/env puppet

$user_groups = [ [“foo”, “bar”], [“baz”, “quux”] ]

notify { $user_groups2: }

output version 2

root@puppetmaster:/etc/puppet/manifests# ./test.pp notice: foo notice: baz notice: bar notice: quux


Related issues

related to Puppet - Bug #2679: Possible regression Rejected 09/25/2009
duplicated by Puppet - Bug #1691: Realization fails if variable is used to represent array ... Duplicate 10/27/2008

History

Updated by James Turnbull over 3 years ago

  • Category set to language
  • Status changed from Unreviewed to Accepted
  • Target version set to 0.24.7
  • 3 changed from Unknown to Medium

Updated by Brice Figureau over 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee set to James Turnbull

AST::ASTArray lacks of a final flatten after evaluating its children.

This is fixed in branch tickets/0.24.x/1682 in my github repository: http://github.com/masterzen/puppet/tree/tickets%2F0.24.x%2F1682

Updated by Brice Figureau over 3 years ago

Oops, I meant “ready for testing”, but instead chose “ready for checking”. The patch didn’t get any review yet, can you please move it to “ready for testing” as I can’t seem to do it?

Updated by Ryan Steele over 3 years ago

I tested this, and it works on 0.24.6. Nice job, Brice.

Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:c7ccc4ba7c42d56595564491ae578a1604c628d1 in branch 0.24.x

Also available in: Atom PDF