Puppet

Since http://projects.reductivelabs.com/repositories/revision/puppet/e6698c2b8624fe2c2bbeef594318e3e8d932d345 the client always shows a warning about forcing the checksum to md5 when source has been set, even when the checksum has already (implicitly or explicitly) been set to md5:

$ cat test.pp 
#!/usr/bin/env puppet

file { "/tmp/target":
    source => "file:///tmp/source",
    checksum => "md5",
}
$ ./test.pp 
warning: //File[/tmp/target]/checksum: Files with source set must use md5 as checksum. Forcing to md5 from md5 for /tmp/target
warning: //File[/tmp/target]/checksum: Files with source set must use md5 as checksum. Forcing to md5 from md5 for /tmp/target

This seems to fix it:

--- puppet/type/file/checksum.rb.old    2008-10-09 19:40:28.000000000 +0200
+++ puppet/type/file/checksum.rb    2008-10-09 19:40:15.000000000 +0200
@@ -53,7 +53,7 @@
         else
             if FileTest.directory?(@resource[:path])
                 return :time
-            elsif @resource[:source]
+            elsif @resource[:source] and not %w{md5 md5lite}.include?(value.to_s)
                 self.warning("Files with source set must use md5 as checksum. Forcing to md5 from %s for %s" % [ value, @resource[:path] ])
                 return :md5
             else

I’m assuming md5lite is also valid, but I’m not sure.