Bug #1640

group for file set on every run

Added by Bart Cortooms almost 2 years ago. Updated almost 2 years ago.

Status:Closed Start:10/08/2008
Priority:High Due date:
Assignee:James Turnbull % Done:

0%

Category:group
Target version:0.24.6
Affected version:0.24.4 Branch:
Keywords:
Votes: 0

Description

Puppet always sets the group for files when using Puppet from a git checkout of git://github.com/jamtur01/puppet.git (commit 80e5c111fd2d227ef076fd0409213f30af13bc56), even though the group is already correct:

$ cat test.pp 
#!/usr/bin/env puppet

file { "/tmp/test":
    owner => "bart",
    group => "users",
    content => "foo",
}
$ ls -l /tmp/test 
-rw-r--r-- 1 bart users 3 Oct  8 15:12 /tmp/test
$ ./test.pp --debug
debug: Creating default schedules
debug: Failed to load library 'ldap' for feature 'ldap'
debug: Finishing transaction 23947101243700 with 0 changes
debug: //File[/tmp/test]/checksum: Initializing checksum hash
debug: //File[/tmp/test]: Creating checksum {md5}acbd18db4cc2f85cedef654fccc4a4d8
debug: //File[/tmp/test]: Changing group
debug: //File[/tmp/test]: 1 change(s)
notice: //File[/tmp/test]/group: group changed 'users' to 'users'
debug: Finishing transaction 23947100318220 with 1 changes
$ ./test.pp --debug
debug: Creating default schedules
debug: Failed to load library 'ldap' for feature 'ldap'
debug: Finishing transaction 23734632218800 with 0 changes
debug: //File[/tmp/test]/checksum: Initializing checksum hash
debug: //File[/tmp/test]: Creating checksum {md5}acbd18db4cc2f85cedef654fccc4a4d8
debug: //File[/tmp/test]: Changing group
debug: //File[/tmp/test]: 1 change(s)
notice: //File[/tmp/test]/group: group changed 'kumina' to 'kumina'
debug: Finishing transaction 23734631293160 with 1 changes

Reverting http://github.com/jamtur01/puppet/commit/63ad84587892e9cab851cf516f7a381c5ea51f90 fixes this for me.

Associated revisions

Revision 2153baed8c6b99f9b77ed2f63fb24433bd72058c
Added by Luke Kanies almost 2 years ago

Fixing #1640 – file groups now no longer get set on every run (this was a regression caused by other work I did).

Signed-off-by: Luke Kanies luke@madstop.com

History

Updated by Bart Cortooms almost 2 years ago

Sorry, the paste of that last run was not correct – it sets the group to ‘users’ on every run.

Updated by Luke Kanies almost 2 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Luke Kanies
  • Priority changed from Normal to High
  • Target version set to 0.24.6

Updated by Luke Kanies almost 2 years ago

  • Status changed from Accepted to Ready for Checkin
  • Assignee changed from Luke Kanies to James Turnbull

Fixed in the tickets/0.24.x/1640 branch in my repo.

Updated by James Turnbull almost 2 years ago

  • Status changed from Ready for Checkin to Closed

Pushed in commit:“2153baed8c6b99f9b77ed2f63fb24433bd72058c” in branch 0.24.x

Also available in: Atom PDF