Bug #1569

createpackage.sh OS X package creation fails if run from conf/osx directory

Added by Kyle C over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:09/09/2008
Priority:Normal Due date:
Assignee:Luke Kanies % Done:

100%
Category:library
Target version:1.5.3
Keywords: Affected Facter version:
Branch:
Votes: 0

Description

A couple bugs:

This one appears to be a copy paste error as it should go up one more level to find install.rb: @@ -37,7 +37,7 @@ elif [ -f “../${INSTALLRB}” ]; then

 installer="$(pwd)/../${INSTALLRB}"

elif [ -f “../../${INSTALLRB}” ]; then – installer=“$(pwd)/../${INSTALLRB}” + installer=“$(pwd)/../../${INSTALLRB}” else

 installer=""

fi

This one fails to actually perform the installation unless you run it from the install.rb folder.

@@ -49,7 +49,8 @@

function install_facter() { echo “Installing Facter to ${pkgroot}” – “${installer}” —destdir=“${pkgroot}” —bindir=“${BINDIR}” —sitelibdir=“${SITELIBDIR}” &> /dev/null + cd “$facter_root” + ./“${INSTALLRB}” —destdir=“${pkgroot}” —bindir=“${BINDIR}” —sitelibdir=“${SITELIBDIR}” &> /dev/null chown -R root:admin “${pkgroot}” }

createpackage_factor_patch (843 Bytes) Kyle C, 09/09/2008 06:22 pm

History

#1
Updated by James Turnbull over 3 years ago

  • Category set to library
  • Status changed from Unreviewed to Accepted
  • Target version changed from 1.5.2 to 1.5.3

#2
Updated by James Turnbull over 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee set to Luke Kanies

Pushed in commit:d4cf657a14b62267837ff7a82ac2ad19b651c369 in branch master.

#3
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:d4cf657a14b62267837ff7a82ac2ad19b651c369.

Also available in: Atom PDF