Puppet

This is the cause of other issues people have reported with running puppet clients < 0.24.5 against the 0.24.5 server when using the local cache.

It was reported as the difference between running puppetd —test and running it as a daemon, but the issue is in fact the use of the local cache.

Clients will report errors like this:

undefined method `-' for #

The problem is that the puppetmaster.freshness XMLRPC call in 0.24.5 is returning Time.now which is not an integer and so when older clients call this method from network/client/master.rb:

def fresh?(facts)
        if Puppet[:ignorecache]
            Puppet.notice "Ignoring cache"
            return false
        end
        unless self.compile_time
            Puppet.debug "No cached compile time"
            return false
        end
        if facts_changed?(facts)
            Puppet.info "Facts have changed; recompiling" unless local?
            return false
        end

        # We're willing to give a 2 second drift
        newcompile = @driver.freshness
        if newcompile - @compile_time.to_i < 1
            return true
        else
            Puppet.debug "Server compile time is %s vs %s" % [newcompile, @compile_time]
            return false
        end
    end

it fails at the line:

if newcompile - @compile_time.to_i < 1

as it’s trying to perform subtraction on an XMLRPC::DateTime object and an integer.

I was going to submit this patch to return Time.now.to_i , but then I spent some time debugging the older code for puppetmaster.freshness which looks like:

        def freshness(client = nil, clientip = nil)
            if Puppet.features.rails? and Puppet[:storeconfigs]
                Puppet::Rails.connect

                host = Puppet::Rails::Host.find_or_create_by_name(client)
                host.last_freshcheck = Time.now
                if clientip and (! host.ip or host.ip == "")
                    host.ip = clientip
                end
                host.save
            end
            if defined? @interpreter
                return @interpreter.parsedate
            else
                return 0
            end
        end

and in fact it always returned 0, so my patch will simply return 0 as well given that this function isn’t called by newer clients and it seemed safest to return the same value as they were getting.

Patch coming now.