Bug #1543

Failures during prefetching kill puppetd

Added by Martha Greenberg over 3 years ago. Updated almost 2 years ago.

Status:Closed Start date:09/02/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

100%
Category:nagios
Target version:0.24.8
Affected Puppet version:0.24.5 Branch:
Keywords:
Votes: 0

Description

This happens when a value for a nagios directive is blank:

notice: /Nagios_host[weblog]/parents: defined 'parents' as ''
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/nagios/nagios_host.cfg(fc0cbab23a4bbffeec46acc879997e2c)
info: /Nagios_host[weblog]: Scheduling refresh of Exec[nagios3 reload]
line 343: syntax error at '
'

History

#1
Updated by James Turnbull over 3 years ago

  • Category set to nagios
  • Status changed from Unreviewed to Accepted

#2
Updated by Luke Kanies about 3 years ago

What is the correct behaviour here? Should I mark all instances of that class as failed, so the file isn’t modified (thus potentially losing information)? Or should I just consider the file to be empty and overwrite it?

#3
Updated by Gary Yuen about 3 years ago

it would probably be best to ignore and not include blank parameters. So a define, for instance, could include all parameters and the resource would use only parameters for which there is a non-nil value.

#4
Updated by Luke Kanies about 3 years ago

That doesn’t really work, because it’s not the parameters that fail, it’s whole files. This means that if there’s a parse error, we might lose a whole set of resources, not just individual parameters.

#5
Updated by Luke Kanies about 3 years ago

  • Subject changed from puppet dies on nagios parse to Failures during prefetching kill puppetd
  • Assignee set to Luke Kanies
  • Target version set to 0.24.8

#6
Updated by Luke Kanies about 3 years ago

  • Status changed from Accepted to Ready For Checkin

Fixed in tickets/0.24.x/1543 in my repo.

#7
Updated by Luke Kanies about 3 years ago

  • Assignee changed from Luke Kanies to James Turnbull

#8
Updated by Luke Kanies almost 3 years ago

  • Status changed from Ready For Checkin to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:6b0c1b9170c69829bdf5956d1dec0949dcc08b35.

Also available in: Atom PDF