Bug #1541

nagios objects write files to clientbucket on every change

Added by Martha Greenberg over 3 years ago. Updated almost 3 years ago.

Status:Closed Start date:09/01/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

100%
Category:nagios
Target version:0.24.8
Affected Puppet version:0.24.5 Branch:
Keywords:
Votes: 0

Description

The nagios_* objects write their configuration files to the clientbucket after every change, even when there are multiple changes in the same puppet run. This makes it extremely slow when you are making a lot of changes at once.

notice: //nagios::server/Nagios_service[puppet-server7]/ensure: created
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/nagios/nagios_service.cfg(e8ab872cbbb1efa834d86ae7db9beaa9)
info: //nagios::server/Nagios_service[puppet-server7]: Scheduling refresh of Exec[nagios3 reload]
notice: //nagios::server/Nagios_service[puppet-server3]/ensure: created
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/nagios/nagios_service.cfg(dd4a71ffd9a9df2ccc8de0e39e85cc2b)
info: //nagios::server/Nagios_service[puppet-server3]: Scheduling refresh of Exec[nagios3 reload]
notice: //nagios::server/Nagios_service[puppet-server5]/ensure: created
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/nagios/nagios_service.cfg(115294d431ffebc6847cf02db470842e)
info: //nagios::server/Nagios_service[puppet-server5]: Scheduling refresh of Exec[nagios3 reload]
notice: //nagios::server/Nagios_service[puppet-server2]/ensure: created
info: Filebucket[/var/lib/puppet/clientbucket]: Adding /etc/nagios/nagios_service.cfg(de78f44281018067170921292fd24e2d)
info: //nagios::server/Nagios_service[puppet-server2]: Scheduling refresh of Exec[nagios3 reload]

Related issues

related to Puppet - Bug #999: Server filebucket doesn't work for ParsedFile types Accepted

History

#1
Updated by James Turnbull over 3 years ago

  • Category set to nagios
  • Status changed from Unreviewed to Accepted

#2
Updated by Luke Kanies about 3 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee set to Luke Kanies

Fixed in the refactor/0.24.x/nagios branch in my repository. Again, because this is for a client it’s written against 0.24.x, but I’ll convert it to master once it’s delivered to the client.

#3
Updated by Luke Kanies about 3 years ago

  • Status changed from In Topic Branch Pending Review to Ready For Checkin
  • Assignee changed from Luke Kanies to James Turnbull
  • Target version set to 0.24.8

Code’s been tested. Both of these nagios commits are in this branch, ftr.

#4
Updated by James Turnbull about 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:897539e857b0da9145f15648b6aa2ef124ec1a19 in branch 0.24.x

#5
Updated by Luke Kanies almost 3 years ago

  • Status changed from Closed to Re-opened

That commit isn’t actually the commit that fixes this.

If you merge my refactor/0.24.x/nagios branch, you’ll actually get the correct commit.

There is one additional commit in that branch, fixing the naming things I apparently broke in Nagios.

#6
Updated by Luke Kanies almost 3 years ago

  • Status changed from Re-opened to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:d5a193a594bbc2194dbf1e5264369ebea0e55880.

Also available in: Atom PDF