Bug #1521

ldapuser and ldappassword options being ignored

Added by Corey Ralph over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:08/19/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:LDAP
Target version:0.24.6
Affected Puppet version:0.24.5 Branch:
Keywords:
Votes: 0

Description

I am attempting to use LDAP nodes using an LDAP server that requires authentication. This fails because the ldapuser and ldappassword config options aren’t being passed to Puppet::Util::Ldap::Connection.new. Simple patch:

--- /usr/src/puppet-0.24.5/lib/puppet/util/ldap/connection.rb   2008-07-08 23:46:19.000000000 +1000
+++ /usr/lib/ruby/1.8/puppet/util/ldap/connection.rb    2008-08-19 17:45:07.964454296 +1000
@@ -17,7 +17,7 @@
               else
                   false
               end
-        new(Puppet[:ldapserver], Puppet[:ldapport], :ssl => ssl)
+        new(Puppet[:ldapserver], Puppet[:ldapport], :ssl => ssl, :user => Puppet[:ldapuser], :password => Puppet[:ldappassword] )
     end

     def close

Related issues

duplicated by Puppet - Bug #1602: Util::Ldap::Connection initialize() doesn't pass user/pas... Duplicate 09/23/2008
duplicated by Puppet - Bug #1599: Util::Ldap::Connection initialize() doesn't pass user/pas... Duplicate 09/23/2008

History

#1
Updated by James Turnbull over 3 years ago

  • Category set to LDAP
  • Status changed from Unreviewed to Needs More Information
  • Assignee set to Luke Kanies
  • Target version set to 0.24.6

#2
Updated by Lawrence Ludwig over 3 years ago

I also had this same issue and this patch fixed it. What additional info do you need to make sure this is included in the next release?

#3
Updated by James Turnbull over 3 years ago

What happens with a non-authenticated connection with those options specified?

#4
Updated by Luke Kanies over 3 years ago

  • Status changed from Needs More Information to Accepted

There are existing tests for the connection class; please update those tests so that they all pass with this patch applied.

Please include in the tests the behaviour for when the user/password aren’t provided.

#5
Updated by Luke Kanies over 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee changed from Luke Kanies to James Turnbull

Fixed in the tickets/0.24.x/1521 branch in my repo.

I didn’t use this diff because it’s not an actual patch and it doesn’t take into account the behaviour when the user/pass aren’t set.

#6
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:77f4fb67fc9efac8ab70c1fc83e86123401b8000 in branch 0.24.x

Also available in: Atom PDF