Feature #1508

HP-UX package provider

Added by Mark Plaksin over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:08/12/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

0%
Category:package
Target version:0.24.6
Affected Puppet version:0.24.5 Branch:
Keywords:
Votes: 0

Description

Attached, mailed to puppet-dev, or grab it from the hpux_pkg_provider branch of my repo: git://github.com/happymcplaksin/puppet.git

0001-Add-HP-UX-package-provider.patch (3.7 kB) Mark Plaksin, 08/12/2008 07:21 pm

History

#1
Updated by Luke Kanies over 3 years ago

  • Category set to package
  • Status changed from Unreviewed to In Topic Branch Pending Review
  • Target version set to 0.24.6

#2
Updated by James Turnbull over 3 years ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient
  • Assignee set to Mark Plaksin

Is this based on HEAD or 0.24.x? Looks like HEAD – can you rebase to 0.24.x please.

#3
Updated by Mark Plaksin over 3 years ago

Oops! I deleted and re-created my puppet repo at github and now the hpux_pkg_provider branch has the patch against 0.24.x.

#4
Updated by Luke Kanies over 3 years ago

All of the code and tests look good, but you’ve got the ‘remove’ test labeled ‘install’ (which makes for two ‘install’ tests).

Also, can you fix the indentation so it’s 4 space?

Once those are fixed I’ll apply the patch.

#5
Updated by Mark Plaksin over 3 years ago

Pushed in commit 297393.

#6
Updated by James Turnbull over 3 years ago

  • Status changed from Code Insufficient to Closed

Pushed in commit:b6609ee in branch 0.24.x

#7
Updated by James Turnbull over 3 years ago

  • Status changed from Closed to Re-opened

Some broken tests – please fix:

1) Puppet::Error in ‘Puppet::Type::User::ProviderHpuxuseradd should add -F when modifying a user’ Command modify is missing /home/james/src/puppet/lib/puppet/provider.rb:115:in modify' /home/james/src/puppet/lib/puppet/provider.rb:131:insend' /home/james/src/puppet/lib/puppet/provider.rb:131:in modify' ./spec/unit/provider/user/hpux.rb:19: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:19:inrun' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in each' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:inrun'

2) Mocha::ExpectationError in ‘Puppet::Type::User::ProviderHpuxuseradd should add -F when deleting a user’

<Mock:0x7fc57895d428>.execute() – expected calls: 1, actual calls: 0

./spec/unit/provider/user/hpux.rb:25: ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:19:in run' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:ineach' ./spec/monkey_patches/add_confine_and_runnable_to_rspec_dsl.rb:17:in `run'

#8
Updated by Andrew Shafer over 3 years ago

  • Status changed from Re-opened to Ready For Checkin
  • Assignee changed from Mark Plaksin to James Turnbull

Fixed failing tests

My github (littleidea) on branch ticket/0.24.x/1508

#9
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:27f0c7d6e7bf3400ccecc6512d6a5d477cb9bea9 in branch 0.24.x

Also available in: Atom PDF