Bug #1506

Storeconfig schema contains duplicate index.

Added by Brice Figureau over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:08/11/2008
Priority:Normal Due date:
Assignee:Brice Figureau % Done:

0%
Category:Rails
Target version:0.24.6
Affected Puppet version:0.24.5 Branch:
Keywords:storeconfig index rails
Votes: 0

Description

The schema generated by storeconfig at the first run (see lib/puppet/rails/database/schema.rb) contains index on the “id” columns of each table. Rails creates “id” columns automatically if there are none and that those created columns are primary keys. If they are primary keys, they are already indexed, so there is no need create another index again which duplicate information and force the database engine to write twice the information.

This has been verified on mysql and sqlite.

History

#1
Updated by Brice Figureau over 3 years ago

A fix is available in my github repository (masterzen/puppet) in the tickets/1506 branch: http://github.com/masterzen/puppet/tree/tickets%2F1506 Direct access to the commit: http://github.com/masterzen/puppet/commit/4a28b0f263b1ba5426fb314899df21fd745f6518

#2
Updated by Luke Kanies over 3 years ago

  • Status changed from Unreviewed to Accepted
  • Assignee set to Luke Kanies
  • Target version changed from 0.24.5 to 0.24.6

#3
Updated by James Turnbull over 3 years ago

  • Status changed from Accepted to Code Insufficient
  • Assignee changed from Luke Kanies to Brice Figureau

Can yoiu rebase on 0.24.x please.

#4
Updated by Brice Figureau over 3 years ago

jamtur01 wrote:

Can yoiu rebase on 0.24.x please.

Yes, of course :–) The result is available in the github masterzen/puppet repository branch tickets/0.24.x/1506 or shorter here: http://github.com/masterzen/puppet/tree/tickets%2F0.24.x%2F1506

and with direct access to the commit here: http://github.com/masterzen/puppet/commit/7accb893d8b4a530aac7ccd402756afb0ce599bd

#5
Updated by James Turnbull over 3 years ago

  • Status changed from Code Insufficient to Closed

Pushed in commit:5851061 in branch 0.24.x

Also available in: Atom PDF