Feature #1501

puppetrun needs ICMP?

Added by John Williams almost 4 years ago. Updated almost 4 years ago.

Status:Closed Start date:08/08/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

100%
Category:executables
Target version:0.24.6 Estimated time:0.50 hour
Affected Puppet version:0.24.5 Branch:
Keywords:puppetrun ICMP
Votes: 0

Description

While setting up puppet and trying puppetrun I noticed it was not working because our firewall setup does not allow ICMP traffic, tcpdump showed that puppetrun does an ICMP echo request, since this was firewalled it fails. When I allow ICMP traffic puppetrun works correctly. Does it really need ICMP? Is it possible to disable it in the configs? I think a lot of companies disable ICMP?

History

#1
Updated by James Turnbull almost 4 years ago

  • Category set to executables
  • Status changed from Unreviewed to Accepted
  • Assignee set to AJ Christensen
  • Target version set to 0.25.0
  • Keywords set to puppetrun ICMP

#2
Updated by Luke Kanies almost 4 years ago

puppetrun currently pings hosts before connecting to them, rather than waiting for timeouts.

I guess this could be switched to just using timeouts, though.

#3
Updated by AJ Christensen almost 4 years ago

  • Status changed from Accepted to In Topic Branch Pending Review
  • Assignee changed from AJ Christensen to James Turnbull
  • % Done changed from 0 to 100
  • Estimated time set to 0.50
  • Affected Puppet version changed from 0.24.4 to 0.24.5

Patch sent to puppet-dev, http://github.com/fujin/puppet/tree/fix1501 rebased against 0.24.x 15/9/08

#4
Updated by Luke Kanies almost 4 years ago

Hmm, I mentioned on the list that I think a timeout should be added, but having thought about it, I don’t think that would work that well, since the work itself can sometimes take a while.

I’d accept this patch.

#5
Updated by James Turnbull almost 4 years ago

  • Status changed from In Topic Branch Pending Review to Closed
  • Target version changed from 0.25.0 to 0.24.6

Pushed in commit:b1ad596 in branch 0.24.x

Also available in: Atom PDF