Bug #1457

Warning about 'not loading confine' should be removed

Added by Digant Kasundra over 3 years ago. Updated almost 2 years ago.

Status:Closed Start date:07/29/2008
Priority:Normal Due date:
Assignee:James Turnbull % Done:

100%
Category:-
Target version:0.24.6
Affected Puppet version:0.24.5 Branch:
Keywords:
Votes: 0

Description

Running puppet using the rpm'ed version of 0.24.5-1 from David Lutterkort’s yum repo generates the following errors which do not seem to affect puppet’s work but appear on each run.

{{{ Running Puppet in one-shot mode. (may take a couple of minutes depending on number of changes) [0;34mdebug: Creating default schedules[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: Failed to load library ‘shadow’ for feature ‘libshadow’[0m [0;34mdebug: Failed to load library ‘ldap’ for feature ‘ldap’[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/private]: Autorequiring File[/var/lib/puppet/ssl][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/public_keys]: Autorequiring File[/var/lib/puppet/ssl][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/certs/ca.pem]: Autorequiring File[/var/lib/puppet/ssl/certs][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/certs/brocksamson.stanford.edu.pem]: Autorequiring File[/var/lib/puppet/ssl/certs][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/certs]: Autorequiring File[/var/lib/puppet/ssl][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/var/lib/puppet/classes.txt]: Autorequiring File[/var/lib/puppet][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/private_keys/brocksamson.stanford.edu.pem]: Autorequiring File[/var/lib/puppet/ssl/private_keys][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/public_keys/brocksamson.stanford.edu.pem]: Autorequiring File[/var/lib/puppet/ssl/public_keys][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/var/lib/puppet/state/state.yaml]: Autorequiring File[/var/lib/puppet/state][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/etc/puppet/puppet.conf]: Autorequiring File[/etc/puppet][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[main]/File[/var/lib/puppet/lib]: Autorequiring File[/var/lib/puppet][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[main]/File[/var/lib/puppet/state]: Autorequiring File[/var/lib/puppet][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/private_keys]: Autorequiring File[/var/lib/puppet/ssl][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[main]/File[/var/lib/puppet/ssl]: Autorequiring File[/var/lib/puppet][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[ssl]/File[/var/lib/puppet/ssl/csr_brocksamson.stanford.edu.pem]: Autorequiring File[/var/lib/puppet/ssl][0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/var/lib/puppet/state/state.yaml]: Changing mode[0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/var/lib/puppet/state/state.yaml]: 1 change(s)[0m [0;34mdebug: /Settings[/etc/puppet/puppet.conf]/Settings[puppetd]/File[/var/lib/puppet/state/state.yaml]/mode: mode changed ‘640’ to ‘660’[0m [0;34mdebug: Finishing transaction 91453739472 with 1 changes[0m [0;34mdebug: Loaded state in 0.01 seconds[0m [0;34mdebug: Puppet::Network::Client::File: defining fileserver.describe[0m [0;34mdebug: Puppet::Network::Client::File: defining fileserver.list[0m [0;34mdebug: Puppet::Network::Client::File: defining fileserver.retrieve[0m [0;32minfo: Retrieving plugins[0m [0;34mdebug: Calling fileserver.list[0m [0;34mdebug: Calling fileserver.describe[0m [0;34mdebug: Calling fileserver.list[0m [0;34mdebug: Calling fileserver.describe[0m [0;34mdebug: Calling fileserver.list[0m [0;34mdebug: Calling fileserver.describe[0m [0;34mdebug: Calling fileserver.list[0m [0;34mdebug: Calling fileserver.describe[0m [0;34mdebug: Finishing transaction 91453877912 with 0 changes[0m [0;34mdebug: Retrieved facts in 0.17 seconds[0m [0;34mdebug: Retrieving catalog[0m [0;34mdebug: Calling puppetmaster.getconfig[0m [0;34mdebug: Retrieved catalog in 3.50 seconds[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: Puppet::Type::Package::ProviderRpm: Executing ‘/bin/rpm —version’[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: Puppet::Type::Package::ProviderAptrpm: Executing ‘/bin/rpm -ql rpm’[0m [0;34mdebug: Puppet::Type::Package::ProviderYum: Executing ‘/bin/rpm —version’[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: Puppet::Type::Package::ProviderUrpmi: Executing ‘/bin/rpm -ql rpm’[0m Could not load confine test ‘operatingsystem’: No such file to load — puppet/provider/confine/operatingsystem [0;34mdebug: file /usr/sbin/update-rc.d does not exist[0m [0;34mdebug: file /sbin/rc-update does not exist[0m [0;34mdebug: file /usr/sbin/svcadm does not exist[0m [0;34mdebug: true value when expecting false[0m [0;34mdebug: file /usr/bin/dscl does not exist[0m [0;34mdebug: file nireport does not exist[0m [0;34mdebug: file pw does not exist[0m [0;32minfo: /Package[jdk]: Adding aliases “java5”[0m [0;34mdebug: Creating default schedules[0m [0;32minfo: Caching catalog at /var/lib/puppet/localconfig.yaml[0m [0;31mnotice: Starting catalog run[0m [0;34mdebug: Loaded state in 0.01 seconds[0m [0;34mdebug: true value when expecting false[0m [0;34mdebug: file /usr/bin/dscl does not exist[0m [0;34mdebug: file nireport does not exist[0m [0;34mdebug: file pw does not exist[0m [0;34mdebug: Prefetching up2date resources for package[0m [0;34mdebug: Puppet::Type::Package::ProviderUp2date: Executing ‘/bin/rpm -qa —nosignature —nodigest —qf ’%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} ‘’[0m [0;34mdebug: Prefetching rpm resources for package[0m [0;34mdebug: Puppet::Type::Package::ProviderRpm: Executing ‘/bin/rpm -qa —nosignature —nodigest —qf ’%{NAME} %|EPOCH?{%{EPOCH}}:{0}| %{VERSION} %{RELEASE} %{ARCH} ‘’[0m

….

[0;32minfo: Sent transaction report in 1.10 seconds[0m [0;31mnotice: Finished catalog run in 8.88 seconds[0m }}}

History

#1
Updated by Luke Kanies over 3 years ago

  • Subject changed from Cannot load confine test 'operatingsystem' to Warning about 'not loading confine' should be removed
  • Status changed from Unreviewed to Accepted
  • Assignee set to Luke Kanies
  • 3 changed from Unknown to Easy

This is just a warning, but you’re probably right that it’s a stupid warning. I’ll fix it.

You must be running ruby with warnings on, somehow, which is why you’re seeing those extra warnings.

#2
Updated by Digant Kasundra over 3 years ago

--- a/lib/puppet/provider/confine.rb
+++ b/lib/puppet/provider/confine.rb
@@ -25,7 +25,7 @@ class Puppet::Provider::Confine
             begin
                 require "puppet/provider/confine/%s" % name
             rescue LoadError => detail
-                unless detail.to_s.include?("no such file")
+                unless detail.to_s.downcase.include?("no such file")
                     warn "Could not load confine test '%s': %s" % [name, detail]
                 end
                 # Could not find file

… should work unless there is no instance where the message might be in lowercase in which case

--- a/lib/puppet/provider/confine.rb
+++ b/lib/puppet/provider/confine.rb
@@ -25,7 +25,7 @@ class Puppet::Provider::Confine
             begin
                 require "puppet/provider/confine/%s" % name
             rescue LoadError => detail
-                unless detail.to_s.include?("no such file")
+                unless detail.to_s.include?("No such file")
                     warn "Could not load confine test '%s': %s" % [name, detail]
                 end
                 # Could not find file

… is what you want.

#3
Updated by Luke Kanies over 3 years ago

  • Status changed from Accepted to Ready For Checkin
  • Assignee changed from Luke Kanies to James Turnbull

This looks right, and I’m assuming you’ve tested it in real life.

I guess we could test it, but it’s just whether warnings are printed or not, so it seems a touch silly.

#4
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:014757047f23b85bb0e35d7a0c79efcec9178077 in branch 0.24.x

#5
Updated by Luke Kanies over 3 years ago

  • Status changed from Closed to Accepted
  • Target version set to 0.24.6

I’m now getting this problem where I didn’t before.

Can you change the code to do a case-insensitive match, rather than ‘include?’?

#6
Updated by James Turnbull over 3 years ago

  • Status changed from Accepted to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:5fb50918ad355116ba85bfe7304baf61a7c8da22.

Also available in: Atom PDF