Bug #1452

puppetlast error: undefined method `version'

Added by micah - over 3 years ago. Updated over 3 years ago.

Status:Closed Start date:07/26/2008
Priority:Low Due date:
Assignee:James Turnbull % Done:

100%
Category:ext
Target version:0.24.6 Estimated time:0.50 hour
Affected Puppet version:0.24.5 Branch:
Keywords:puppetlast
Votes: 0

Description

When running puppetlast on the puppetmaster using 0.25, the following error is produced:

root@puppetmaster:/root# /usr/bin/puppetlast puppetlast error: undefined method `version' for #<Puppet::Node::Facts:0xb7470470> root@puppetmaster:/root#

History

#1
Updated by micah - over 3 years ago

  • Affected Puppet version changed from 0.25.0 to 0.24.5

#2
Updated by micah - over 3 years ago

  • Status changed from Unreviewed to Ready For Checkin

The following commit fixes this problem:

http://github.com/fujin/puppet/commit/c85797f2ff19cb572d46e85a73d11def68e67535

I tested it and it works.

#3
Updated by AJ Christensen over 3 years ago

  • Assignee set to James Turnbull
  • Priority changed from Normal to Low
  • Target version set to 0.24.5
  • % Done changed from 0 to 100
  • Estimated time set to 0.50
  • 3 changed from Unknown to Trivial
  • Patch changed from None to Code

Fix available branch 1425 @ http://github.com/fujin/puppet/commits/fix1452

Took the opportunity to tidy up a little code.

#4
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:971af69b7388cf5155bb124246f2a697578cc6e9 in branch 0.24.x

#5
Updated by AJ Christensen over 3 years ago

  • Status changed from Closed to Unreviewed

Reopening as per Luke’s comments on the dev list. May want to revert that commit, James (sorry)

#6
Updated by AJ Christensen over 3 years ago

  • Status changed from Unreviewed to Accepted
  • Patch changed from Code to Insufficient

Sending email to dev list with my proposed fix(es): http://github.com/fujin/puppet/tree/fix1452 http://github.com/fujin/puppet/commit/5db427007b9148893f1060fbc32387bdfff8b538 http://github.com/fujin/puppet/commit/ffb4ef3dacaf5ca479aeb79f51bf0cea12c269af

#7
Updated by AJ Christensen over 3 years ago

Tests @ http://github.com/fujin/puppet/commit/41786d9684dfda724fba4ad7bde2196938b7d9d7

#8
Updated by AJ Christensen over 3 years ago

  • Patch changed from Insufficient to Tests

#9
Updated by Luke Kanies over 3 years ago

  • Status changed from Accepted to Ready For Checkin

#10
Updated by James Turnbull over 3 years ago

  • Status changed from Ready For Checkin to Closed

Update pushed in commit:2a3d195402900aa31843f7a7ff78026409cf43f5 in branch 0.24.x

#11
Updated by AJ Christensen over 3 years ago

  • Status changed from Closed to Re-opened
  • Assignee changed from James Turnbull to AJ Christensen

#12
Updated by AJ Christensen over 3 years ago

  • Status changed from Re-opened to In Topic Branch Pending Review
  • Assignee changed from AJ Christensen to James Turnbull

Puppetlast didn’t work on systems with more than 1 node, as Puppet::Node::Fact doesn’t have an <=> method (obviously). I’ve implemented a simple string sort based on the node name, a-z.

riddley coulda updated the ticket.. oh well. Rebased today, sent patch to -dev.

http://github.com/fujin/puppet/tree/fix1452

#13
Updated by James Turnbull over 3 years ago

  • Status changed from In Topic Branch Pending Review to Closed
  • Target version changed from 0.24.5 to 0.24.6

Pushed in commit:1729de1 in branch 0.24.x

Also available in: Atom PDF