Puppet

No patch unfortunately (I’m on a deadline to get Tomcat and Glassfish playing nicely), however I’d suggest:

• Red / hi-red: Critical error
• Purple / hi-purple: Warnings
• Green / hi-green: Normal / notice
• White / hi-white: Debug

The only issue with green and red is that colour-blind users might not be able to determine the difference based on colour.

Is it worth making the colours configurable in the .conf file? It has to be parsed anyway.

There’s no such thing as a “color” in the terminal, only terminal codes that translate to colors. I need to know what terminal codes people recommend, since I have no idea how to turn the colors into the right codes. Someone who has normal terminal colors will need to do the reverse translation for me.

As to make them configurable, it seems slightly overkill but I guess I’m not entirely opposed.

Ah, duh.

Debug as white?

I’ll let others comment on the colors. Does this work for people?

Yeah, I’m not sure about white myself, but it was anything but dark blue which is nigh impossible to read on a dark screen. Hence the suggestion of making that array customisable somehow, even if it’s just two colour scheme choices (hi vs low) – low is sometimes hard to read on a black background, and hi colours on a light background is equally hard to read. The only other problem with that approach is that there are 8 levels, and 7 colours.

ANSI also gives you background colour control and underlining, but I’m content with just being able to use hi/bold colours.

The solution to unreadable colors on your terminal is to change those colors so they’re readable. I actually prefer the blue as a debug color, but of course you’ll have to make it readable for that to work.

The new colors work for me, much better than before.

Luke,

Regarding ‘just change my terminal interpretation of color codes’ – konsole doesn’t seem to support that, and I have to admit, I’ve never needed to do that before. As an example, my preferred editor (vim) has a boatload of pre-configured colour schemes, and I just pick one that works with my terminal setup (dark background vs light). putty, on the other hand, does support ANSI remapping, but drives me nuts.

luke wrote:

cricalix wrote:

Luke,

Regarding ‘just change my terminal interpretation of color codes’ – konsole doesn’t seem to support that, and I have to admit, I’ve never needed to do that before. As an example, my preferred editor (vim) has a boatload of pre-configured colour schemes, and I just pick one that works with my terminal setup (dark background vs light). putty, on the other hand, does support ANSI remapping, but drives me nuts.

But isn’t vim limited to just those color codes that your terminal supports? Or is it somehow magically showing more colors than your terminal can show?

I’m essentially fine with this patch, and if it pisses me off enough, I’ll make it configurable, I guess.

James, I haven’t tested the patch or anything, so at least make sure it’s syntactically valid and stuff before merging. http://en.wikipedia.org/wiki/ANSI_escape_code or http://www.ecma-international.org/publications/files/ECMA-ST/Ecma-048.pdf (esp. pp. 61-62) if you happen to enjoy pain.