Bug #12484

Trailing space is allowed in dashboard parameters

Added by James Turnbull 3 months ago. Updated 3 months ago.

Status:Closed Start date:02/07/2012
Priority:Normal Due date:
Assignee:Daniel Sauble % Done:

0%

Category:-
Target version:1.2.6
Keywords: Affected URL:
Branch: Affected Dashboard version:1.2.5
Votes: 1

Description

In puppet dashboard, Parameters setup for key value pairs is trailing whitespace sensitive. ie. (setting up Key “paramA” = “somevalue” is NOT equal to “paramA ” = “somevalue”)

This is especially undesirable when

a) when we try to copy a key name from group A (highlight and copy) to another group, a trailing space is added in the edit group page when we paste to it

b) there is no easy way on the main group page to tell whether a key has trailing space or not.

c) Manifests cannot reference a key (global variable) with trailing space without doing ugly escapes in the manifest

So I think the dashboard need to be smart enough to get rid of the trailing spaces when user is editing the group.

History

Updated by James Turnbull 3 months ago

  • Status changed from Unreviewed to Needs Decision
  • Assignee set to Jason McKerr
  • Affected Dashboard version set to 1.2.5

Updated by Randall Hansen 3 months ago

  • Status changed from Needs Decision to Accepted
  • Assignee changed from Jason McKerr to Daniel Sauble

This is a stupid bug; we should fix it soon. I agree with the proposed solution of trimming whitespace on save.

Updated by Daniel Sauble 3 months ago

  • Status changed from Accepted to Investigating

When existing groups are edited, all existing key/value parameters will be revalidated and stripped of trailing whitespace. This may break manifests that depend on those spaces. Do we care about backwards compatibility with regards to this?

Updated by James Turnbull 3 months ago

No. Def. not.

Updated by Daniel Sauble 3 months ago

  • Status changed from Investigating to In Topic Branch Pending Review

Updated by Daniel Pittman 3 months ago

  • Status changed from In Topic Branch Pending Review to Tests Insufficient

The test code doesn’t even load. Please run the spec tests before submitting.

Updated by Daniel Sauble 3 months ago

  • Status changed from Tests Insufficient to In Topic Branch Pending Review

Updated by Daniel Sauble 3 months ago

Fixed.

Updated by Daniel Pittman 3 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release
  • Target version set to 142

Updated by Matthaus Litteken 3 months ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 142 to 1.2.6

released in 1.2.6rc1

Also available in: Atom PDF