Bug #12269
Puppet fails to sort `Puppet::Type` instances when more than one cycle exists in a graph.
| Status: | Merged - Pending Release | Start date: | 01/29/2012 | |
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Deepak Giridharagopal |
% Done: | 0% |
|
| Category: | Doh! | |||
| Target version: | 2.7.12 | |||
| Affected Puppet version: | 2.7.10 | Branch: | ||
| Keywords: | ||||
| Votes: | 0 |
Description
When #11996 was fixed, the change was restricted to sorting the cycles detected using proxy keys – sort_by – rather than adding sorting to the Puppet::Type class. The sorting itself was needed to ensure consistent output of the cycles found.
Using a proxy key for sorting was less intrusive, but clearly not less risky, since several issues have cropped up from the change.
The specific failure is that when there is more than one cycle, each is internally sorted, then the entire set are sorted. The later doesn’t stringify the type instances correctly, so tried to compare two objects that can’t be ordered…
Related issues
History
Updated by Daniel Pittman 4 months ago
- Status changed from Accepted to In Topic Branch Pending Review
- Assignee deleted (
Daniel Pittman)
https://github.com/puppetlabs/puppet/pull/425 contains the fixes for this, and additional testing to make sure we don’t regress on the subject.
Updated by Deepak Giridharagopal 3 months ago
- Status changed from In Topic Branch Pending Review to Merged - Pending Release
Updated by Daniel Pittman 2 months ago
- Assignee set to Deepak Giridharagopal
- Target version changed from 2.7.x to 2.7.12
I think this shipped with 2.7.12; Deepak, can you please confirm, as you merged it?