Feature #12080

Enhance Faces console logging

Added by Kelsey Hightower 4 months ago. Updated 3 months ago.

Status:Closed Start date:01/23/2012
Priority:Normal Due date:01/27/2012
Assignee:Pieter van de Bruggen % Done:

100%
Category:Faces
Target version:2.7.12 Estimated time:5.00 hours
Affected Puppet version: Branch:https://github.com/pvande/puppet/tree/tickets/2.7.x/12080-telly-prototype-console
Keywords:geordi
Votes: 0

Description

We should have the ability to log warnings, errors, and notices to stderr, with better formatting and colors:

Puppet::Face.err "This error will go to stderr with nice formatting"

We should also have the ability to color specific sections of a given string:

"This is a red #{Puppet::Face.colorize(:red, 'string'}"

Related issues

related to Puppet - Feature #12251: Colorized puppet module list output Rejected 01/27/2012
related to Puppet - Bug #12254: puppet module uninstall colorization Rejected 01/27/2012

History

#1
Updated by Kelsey Hightower 4 months ago

  • % Done changed from 70 to 100

Team Geordi is working on enhancing Faces console output. We need better control over what gets logged to stderr and stdout including custom colors and formatting required by UX designs.

#2
Updated by Kelsey Hightower 4 months ago

  • Branch changed from https://github.com/kelseyhightower/puppet/tree/WIP/2.7.x/add_custom_console_logging_to_faces to https://github.com/kelseyhightower/puppet/tree/ticket/2.7.x/12080_add_custom_console_logging_to_faces

#3
Updated by Kelsey Hightower 4 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

Pending review

A pull request has been issued: Pull 390

Unrelated failing specs

The seems to be some unrelated specs that are failing with, or without this patch.

Finished in 191.33 seconds
14580 examples, 4 failures, 87 pending

Failed examples:

# Puppet::SSL::CertificateAuthority when signing certificates should save valid certificates
rspec ./spec/integration/ssl/certificate_authority_spec.rb:113
# Puppet::Application::Device when running for each device should cleanup the vardir setting after the run
rspec ./spec/unit/application/device_spec.rb:322 
# Puppet::Application::Device when running for each device should cleanup the confdir setting after the run
rspec ./spec/unit/application/device_spec.rb:322
# Puppet::Application::Device when running for each device should cleanup the certname setting after the run 
rspec ./spec/unit/application/device_spec.rb:332

#4
Updated by Kelsey Hightower 4 months ago

  • Status changed from In Topic Branch Pending Review to Code Insufficient
  • Assignee changed from Kelsey Hightower to Pieter van de Bruggen

Based on the feedback for this pull request, we will engage UX to hopefully find a middle ground on the requirements calling for this change. The proposed changes introduce some potentially breaking compatibility issues for the 2.7.x release.

While it’s technically possible to address the comments in the pull request, the bigger issue of breaking compatibility or causing inconsistencies should not be over looked.

After speaking with Pieter this morning, I’m reassigning this ticket to him while we works on a middle ground for this enhancement. I do not plan to continue working on this patch until this “middle ground” is reached.

#5
Updated by Daniel Pittman 3 months ago

  • Status changed from Code Insufficient to Merged - Pending Release
  • Target version changed from 2.7.x to 2.7.11

#6
Updated by Pieter van de Bruggen 3 months ago

  • Branch changed from https://github.com/kelseyhightower/puppet/tree/ticket/2.7.x/12080_add_custom_console_logging_to_faces to https://github.com/pvande/puppet/tree/tickets/2.7.x/12080-telly-prototype-console

#7
Updated by Matthaus Litteken 3 months ago

  • Status changed from Merged - Pending Release to Closed
  • Target version changed from 2.7.11 to 2.7.12

Released in Puppet 2.7.12rc1

Also available in: Atom PDF