Bug #12077

Add pciutils RPM dependency

Added by Dominic Cleal 4 months ago. Updated 4 months ago.

Status:Closed Start date:01/22/2012
Priority:Normal Due date:
Assignee:Moses Mendoza % Done:

0%
Category:- Spent time: -
Target version:-
Patch: Branch:
Keywords:rpm
Votes: 0

Description

Facter uses both lspci and dmidecode to determine the virtual/is_virtual facts, so should also depend on the pciutils package. Also see RHBZ#783749 where it’s being added in Fedora (Todd also mentions net-tools, but that’s probably a mandatory package).

History

#1
Updated by Ken Barber 4 months ago

  • Status changed from Unreviewed to Needs Decision

#2
Updated by Ken Barber 4 months ago

  • Assignee set to Michael Stahnke

Mike – I’m okay with this in principle. Thoughts?

#3
Updated by Michael Stahnke 4 months ago

  • Status changed from Needs Decision to Accepted

Seems reasonable to me. This would allow for a refactoring of facts around virtual to make them quite a bit better as well.

I’ll see if I can have one of my guys get to this during the week. I realize it’s a small change. I’ll probably send a note out to all of our distro contacts as well.

#4
Updated by Michael Stahnke 4 months ago

  • Project changed from Facter to Puppet Community Package Repository
  • Category deleted (installation)
  • Support Urls deleted ()

#5
Updated by Michael Stahnke 4 months ago

  • Assignee changed from Michael Stahnke to Moses Mendoza

#6
Updated by Moses Mendoza 4 months ago

  • Status changed from Accepted to In Topic Branch Pending Review

Added dependency of pciutils to facter/conf/redhat/facter.spec. See https://github.com/puppetlabs/facter/pull/155

#7
Updated by Ken Barber 4 months ago

  • Status changed from In Topic Branch Pending Review to Merged - Pending Release

Not sure if I’m meant to change the status here, but its merged :–). Thanks guys.

#8
Updated by Todd Zullinger 4 months ago

On Fedora and RHEL/CentOS, I’ll also be adding net-tools to make the use of arp, dnsdomainname, hostname, and ifconfig explicit. It’d be very hard to install a system without these, but it doesn’t hurt to add it.

Yell if you want me to submit the one line patch. It’s probably easier to just add “Requires: net-tools” to the spec file.

#9
Updated by Matthaus Litteken 4 months ago

  • Status changed from Merged - Pending Release to Closed

Released in facter 1.6.5

Also available in: Atom PDF