Feature #1195

Patch to make the Gentoo puppetmaster rc-script openrc compatible

Added by Tais Hansen about 4 years ago. Updated over 3 years ago.

Status:Closed Start date:
Priority:Normal Due date:
Assignee:Tais Hansen % Done:

100%
Category:Gentoo
Target version:0.25.0
Affected Puppet version: Branch:
Keywords:
Votes: 0

Description

Gentoo is switching to openrc, which breaks the puppetmaster rc-script. The attached patch fixes the problem.

0006-Fixed-openrc-compatability.patch (974 Bytes) Tais Hansen, 04/17/2008 11:46 am

puppet-0.24.4-openrc_initd.patch (624 Bytes) Tiziano Müller, 06/16/2008 09:43 am

puppetmaster.init (1.4 kB) Tiziano Müller, 06/16/2008 09:44 am

History

#1
Updated by James Turnbull about 4 years ago

  • Status changed from 1 to 2

What versions does this impact? I suspect it’d be better to maintain some backward compatibility for older releases.

#2
Updated by Tais Hansen about 4 years ago

This changes is backwards compatible.

openrc includes a version of start-stop-daemon which requires (as opposed to previously being optional) scripts to be started with their interpreter or with a specified pidfile.

#3
Updated by James Turnbull about 4 years ago

  • Status changed from 2 to 1

Pushed in commit:0a5d8a639014495388b2b6c87c295ab4877f9139 in branch 0.24.x

#4
Updated by James Turnbull about 4 years ago

Not being a Gentoo person does this impact the gentoo service provider at all?

#5
Updated by Peter Meier about 4 years ago

this is about the init.d script and won’t affect any puppet internals.

#6
Updated by James Turnbull about 4 years ago

No – I think you’re missing my point. Is this a move to a new init system? If which case does the gentoo provider for the service type need updating? Will the same commands still enable, disable, start/stop, etc services?

#7
Updated by Peter Meier about 4 years ago

sorry i didn’t realize that your question goes so far. ;) according to http://www.gentoo.org/doc/en/openrc-migration.xml it will still use init.d-scripts and the rc-update scripts. which is what the current service-provider (provider/service/gentoo.rb) is using. so imho: no it won’t break anything.

#8
Updated by Luke Kanies about 4 years ago

  • Status changed from 1 to Closed
  • 7 set to fixed

Merged and pushed.

Thanks for delving deeper into this, James, and thanks for the more detail, immerda.

#9
Updated by Tiziano Müller almost 4 years ago

The former patch doesn’t fix the issue. Attached is a patch which does. It doesn’t break compatibility with older versions (I’ve tested it with baselayout-2 and baselayout-1).

#10
Updated by Tiziano Müller almost 4 years ago

The puppetmasterd init-file is also affected. For some reason we don’t actually use the one provided in puppet-0.24.4 so I’m going to attach the complete file.

#11
Updated by James Turnbull almost 4 years ago

  • Category set to Gentoo
  • Status changed from Unreviewed to Ready For Checkin
  • Target version set to 0.24.5

#12
Updated by James Turnbull almost 4 years ago

  • Assignee changed from Luke Kanies to James Turnbull

#13
Updated by James Turnbull almost 4 years ago

  • Status changed from Ready For Checkin to Closed

Pushed in commit:17afb8afa0f1c3c58f2947f62938d262ae91b3c1 in branch 0.24.x

#14
Updated by Tais Hansen over 3 years ago

  • Status changed from Closed to Re-opened

The updates submitted by dev-zero have been reverted in gentoo since they prevent other ruby scripts from running on the gentoo machine. The original patch I submitted works as intended.

See: http://bugs.gentoo.org/show_bug.cgi?id=237071 and http://bugs.gentoo.org/show_bug.cgi?id=237712

#15
Updated by James Turnbull over 3 years ago

  • Target version changed from 0.24.5 to 0.24.6

#16
Updated by James Turnbull over 3 years ago

  • Status changed from Re-opened to Code Insufficient
  • Assignee changed from James Turnbull to Tais Hansen

Can someone please do a patch based on 0.24.x that def. is what the Gentoo stuff should look like please.

#17
Updated by James Turnbull over 3 years ago

If I don’t get an answer on this it’s going to be bumped… tick-tock.

#18
Updated by James Turnbull over 3 years ago

  • Target version changed from 0.24.6 to 0.25.0

Due to a lack of response this hasn’t made 0.24.6

#19
Updated by James Turnbull over 3 years ago

  • Status changed from Code Insufficient to Closed
  • % Done changed from 0 to 100

Applied in changeset commit:0a5d8a639014495388b2b6c87c295ab4877f9139.

Also available in: Atom PDF