Bug #1167

error reporting for variable expansion in settings is not-sane

Added by Sam Quigley about 4 years ago. Updated almost 4 years ago.

Status:Closed Start date:
Priority:Normal Due date:
Assignee:AJ Christensen % Done:

0%
Category:settings
Target version:0.24.5
Affected Puppet version: Branch:
Keywords:
Votes: 0

Description

Don’t ask me how I know this, but if you set pluginsource to something containing a variable — say, for example, “pluginsource = puppet://$puppet_server/plugins”, you get a crazy set of errors:

debug: No path given for plugins mount; creating a special [[PluginMount]]
debug: Creating interpreter
/usr/lib/ruby/1.8/puppet/util/settings.rb:125:in @convert'
/usr/lib/ruby/1.8/puppet/util/settings.rb:120:in @gsub'
/usr/lib/ruby/1.8/puppet/util/settings.rb:120:in @convert'
/usr/lib/ruby/1.8/puppet/util/settings.rb:728:in @value'
/usr/lib/ruby/1.8/puppet/util/settings.rb:1103:in @value'
/usr/lib/ruby/1.8/puppet/util/settings.rb:495:in @section_to_transportable'
/usr/lib/ruby/1.8/puppet/util/settings.rb:436:in @persection'
/usr/lib/ruby/1.8/puppet/util/settings.rb:143:in @each'
/usr/lib/ruby/1.8/puppet/util/settings.rb:142:in @each'
/usr/lib/ruby/1.8/puppet/util/settings.rb:434:in @persection'
/usr/lib/ruby/1.8/puppet/util/settings.rb:490:in @section_to_transportable'
/usr/lib/ruby/1.8/puppet/util/settings.rb:633:in @to_transportable'
/usr/lib/ruby/1.8/puppet/util/settings.rb:632:in @each'
/usr/lib/ruby/1.8/puppet/util/settings.rb:632:in @to_transportable'
/usr/lib/ruby/1.8/puppet/util/settings.rb:660:in @use'
/usr/lib/ruby/1.8/sync.rb:230:in @synchronize'
/usr/lib/ruby/1.8/puppet/util/settings.rb:655:in @use'
/usr/lib/ruby/1.8/puppet/network/handler/report.rb:21:in @initialize'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:140:in @new'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:140:in @setup_handlers'
/usr/share/rails/activerecord/lib/../../activesupport/lib/active_support/inflector.rb:250:in @collect'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:135:in @each'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:135:in @collect'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:135:in @setup_handlers'
/usr/lib/ruby/1.8/puppet/network/http_server/webrick.rb:80:in @initialize'
/usr/sbin/puppetmasterd:237:in @new'
/usr/sbin/puppetmasterd:237
undefined local variable or method @parent' for #

Getting rid of that line in puppet.conf makes the error go away…

History

#1
Updated by AJ Christensen about 4 years ago

  • Status changed from 1 to 2

Accepted, replicated;

config (note that $puppet_server is not valid):

[puppetd]
pluginsync=true
diff_args=-u
server=puppet.junglist.gen.nz
pluginsource=puppet://$puppet_server/plugins

output:

root@junglist (branch: master) /etc/puppet# puppetd --test
info: Loading fact configured_ntp_servers
info: Loading fact netmask
info: Loading fact acpi_available
info: Loading fact interfaces
/usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:125:in @convert': undefined local variable or method @parent' for # (NameError)
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:120:in @gsub'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:120:in @convert'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:728:in @value'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:1103:in @value'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:495:in @section_to_transportable'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:436:in @persection'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:143:in @each'
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:142:in @each'
         ... 7 levels...
        from /usr/local/lib/site_ruby/1.8/puppet/util/settings.rb:655:in @use'
        from /usr/local/lib/site_ruby/1.8/puppet/network/client/master.rb:206:in @initialize'
        from /usr/bin/puppetd:322:in @new'
        from /usr/bin/puppetd:322

Proposed fix: ensure that error reporting for variable expansion in settings is sane. Feel free to supply patch.

#2
Updated by Luke Kanies about 4 years ago

  • Status changed from 2 to Closed
  • 7 set to fixed

This should have been fixed when #1218 was fixed.

#3
Updated by James Turnbull almost 4 years ago

  • Target version changed from 4 to 0.24.5

Also available in: Atom PDF